From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Hennerich Subject: Re: [PATCH v5] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs Date: Tue, 5 Apr 2016 09:21:13 +0200 Message-ID: <57036769.4070102@analog.com> References: <1458721195-28915-1-git-send-email-michael.hennerich@analog.com> <5700E4E8.40304@kernel.org> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5700E4E8.40304@kernel.org> Sender: linux-gpio-owner@vger.kernel.org To: Jonathan Cameron , Linus Walleij Cc: Alexandre Courbot , Lars-Peter Clausen , Hartmut Knaack , Paul Cercueil , Rob Herring , =?UTF-8?Q?Pawe=c5=82_Moll?= , Mark Rutland , "ijc+devicetree@hellion.org.uk" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 04/03/2016 11:39 AM, Jonathan Cameron wrote: > On 31/03/16 09:01, Linus Walleij wrote: >> On Wed, Mar 23, 2016 at 9:19 AM, wrote: >> >>> From: Paul Cercueil >>> >>> This patch adds support for the AD5592R (spi) and AD5593R (i2c) >>> ADC/DAC/GPIO devices. >>> >>> Signed-off-by: Paul Cercueil >>> Signed-off-by: Michael Hennerich >> >> For this v5 version: >> Reviewed-by: Linus Walleij >> >> I'm fine with this new gpiochip driver being merged into the >> IIO tree. >> > Cool, Paul / Michael, > > I still had a few trivial outstanding comments. Please remember to add > this reviewed-by to V6. Hi Jonathan, Sorry I missed these - With the comment added to the CH_MODE_DAC_AND_ADC description in the bindings. Do you think we need another ACK from Rob? -- Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif