From: Shannon Zhao <zhaoshenglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Julien Grall <julien.grall-5wv7dgnIgG8@public.gmane.org>,
Shannon Zhao
<shannon.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
sstabellini-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
peter.huangpeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
xen-devel-GuqFBffKawuEi8DpZVb4nw@public.gmane.org
Subject: Re: [PATCH v10 06/17] Xen: ARM: Add support for mapping platform device mmio
Date: Thu, 7 Apr 2016 09:37:01 +0800 [thread overview]
Message-ID: <5705B9BD.1020403@huawei.com> (raw)
In-Reply-To: <5704FE2C.5000902-5wv7dgnIgG8@public.gmane.org>
On 2016/4/6 20:16, Julien Grall wrote:
>> + gpfns[j] = XEN_PFN_DOWN(r->start) + j;
>> + idxs[j] = XEN_PFN_DOWN(r->start) + j;
>> + }
>> +
>> + xatp.domid = DOMID_SELF;
>> + xatp.size = nr;
>> + xatp.space = XENMAPSPACE_dev_mmio;
>> +
>> + set_xen_guest_handle(xatp.gpfns, gpfns);
>> + set_xen_guest_handle(xatp.idxs, idxs);
>> + set_xen_guest_handle(xatp.errs, errs);
>> +
>> + rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap_range, &xatp);
>> + kfree(gpfns);
>> + kfree(idxs);
>> + kfree(errs);
>> + if (rc)
>> + return rc;
>
> Shouldn't we redo the mapping if the hypercall fails?
Hmm, why? If it fails again when we redo the mapping, what should we do
then? Redo again?
I think if it fails at the first time it will always fail no matter how
many times we do.
Thanks,
--
Shannon
next prev parent reply other threads:[~2016-04-07 1:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 15:48 [PATCH v10 00/17] Add ACPI support for Xen Dom0 on ARM64 Shannon Zhao
2016-04-01 15:48 ` [PATCH v10 01/17] Xen: ACPI: Hide UART used by Xen Shannon Zhao
2016-04-01 19:21 ` Rafael J. Wysocki
2016-04-01 15:49 ` [PATCH v10 03/17] Xen: xlate: Use page_to_xen_pfn instead of page_to_pfn Shannon Zhao
[not found] ` <1459525755-36968-4-git-send-email-shannon.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-06 11:42 ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 04/17] arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table Shannon Zhao
[not found] ` <1459525755-36968-5-git-send-email-shannon.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-06 11:43 ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 06/17] Xen: ARM: Add support for mapping platform device mmio Shannon Zhao
[not found] ` <1459525755-36968-7-git-send-email-shannon.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-06 12:16 ` Julien Grall
[not found] ` <5704FE2C.5000902-5wv7dgnIgG8@public.gmane.org>
2016-04-07 1:37 ` Shannon Zhao [this message]
2016-04-07 10:32 ` Julien Grall
[not found] ` <57063752.4020805-5wv7dgnIgG8@public.gmane.org>
2016-04-07 11:25 ` Shannon Zhao
[not found] ` <1459525755-36968-1-git-send-email-shannon.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-01 15:49 ` [PATCH v10 02/17] xen/grant-table: Move xlated_setup_gnttab_pages to common place Shannon Zhao
[not found] ` <1459525755-36968-3-git-send-email-shannon.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-06 11:40 ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 05/17] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio Shannon Zhao
[not found] ` <1459525755-36968-6-git-send-email-shannon.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-06 11:44 ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 07/17] Xen: ARM: Add support for mapping AMBA device mmio Shannon Zhao
[not found] ` <1459525755-36968-8-git-send-email-shannon.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-06 12:26 ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 13/17] ARM: Xen: Document UEFI support on Xen ARM virtual platforms Shannon Zhao
2016-04-06 11:32 ` [PATCH v10 00/17] Add ACPI support for Xen Dom0 on ARM64 Julien Grall
[not found] ` <5704F3E1.7020508-5wv7dgnIgG8@public.gmane.org>
2016-04-07 1:39 ` Shannon Zhao
2016-04-07 10:34 ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 08/17] Xen: public/hvm: sync changes of HVM_PARAM_CALLBACK_VIA ABI from Xen Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 09/17] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ Shannon Zhao
[not found] ` <1459525755-36968-10-git-send-email-shannon.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-06 12:29 ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI Shannon Zhao
[not found] ` <1459525755-36968-11-git-send-email-shannon.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-06 12:31 ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 11/17] ARM: XEN: Move xen_early_init() before efi_init() Shannon Zhao
2016-04-06 12:35 ` Julien Grall
2016-04-01 15:49 ` [PATCH v10 12/17] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 14/17] XEN: EFI: Move x86 specific codes to architecture directory Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 15/17] ARM64: XEN: Add a function to initialize Xen specific UEFI runtime services Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 16/17] FDT: Add a helper to get the subnode by given name Shannon Zhao
2016-04-01 15:49 ` [PATCH v10 17/17] Xen: EFI: Parse DT parameters for Xen specific UEFI Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5705B9BD.1020403@huawei.com \
--to=zhaoshenglong-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=david.vrabel-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=julien.grall-5wv7dgnIgG8@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=peter.huangpeng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=shannon.zhao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=sstabellini-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
--cc=xen-devel-GuqFBffKawuEi8DpZVb4nw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).