From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Ujfalusi Subject: Re: [alsa-devel] [PATCH 6/6] ARM: DTS: da850: Add McBSP0 and McBSP1 Date: Thu, 7 Apr 2016 15:45:47 +0300 Message-ID: <5706567B.5000501@ti.com> References: <1459948893-4206-1-git-send-email-petr@barix.com> <1459948893-4206-7-git-send-email-petr@barix.com> <570645B4.6060606@ti.com> <57064F8B.3020501@barix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <57064F8B.3020501-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Petr Kulhavy , nsekhar-l0cyMroinI0@public.gmane.org, khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org List-Id: devicetree@vger.kernel.org On 04/07/16 15:16, Petr Kulhavy wrote: >=20 > On 07.04.2016 13:34, Peter Ujfalusi wrote: >> On 04/06/16 16:21, Petr Kulhavy wrote: >>> Add SoC nodes for McBSP0 and McBSP1 as well as the corresponding pi= nmux >>> configurations. >>> >>> Signed-off-by: Petr Kulhavy >>> --- >>> arch/arm/boot/dts/da850.dtsi | 45 >>> +++++++++++++++++++++++++++++++++++++++++++- >>> 1 file changed, 44 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850= =2Edtsi >>> index 5996e765e59c..9e2b1e97377c 100644 >>> --- a/arch/arm/boot/dts/da850.dtsi >>> +++ b/arch/arm/boot/dts/da850.dtsi >>> @@ -148,7 +148,24 @@ >>> 0xc 0x88888888 0xffffffff >>> >; >>> }; >>> - >>> + mcbsp0_pins: pinmux_mcbsp0_pins { >>> + pinctrl-single,bits =3D < >>> + /* PINMUX2: >>> + * CLKS0, DX0, DR0, FSX0 >>> + * FSR0, CLKX0, CLKR0 >>> + */ >>> + 0x8 0x02222220 0xfffffff0 >>> + >; >>> + }; >>> + mcbsp1_pins: pinmux_mcbsp1_pins { >>> + pinctrl-single,bits =3D < >>> + /* PINMUX1: >>> + * CLKS1, DX1, DR1, FSX1, >>> + * FSR1, CLKX1, CLKR1 >>> + */ >>> + 0x4 0x22222220 0xfffffff0 >> This will conflict with the mcasp0_pins in da850-evm as AXR11 and AX= R12 is >> used by the board for audio. When I say conflict, I mean that audio = will be >> completely broken on the board. >=20 > I agree with you, the EVM uses the pins for other peripherals. Howeve= r I > understand that the da850.dtsi is a generic description of the DA850 = platform. > Other DA850 based designs that use the McBSP will not have conflicts.= For > instance my two AM1808 based boards don't use the McASP. > Of course the board's DTS must enable only non-conflicting peripheral= s/pinmux > configurations. > But having the pinmuxes defined does not break anything and actually = helps > creating the DTS file. I think what the da850.dtsi does is wrong. The dtsi file should not set= any pinmux, those need to be set by the board .dts files If one board uses = McASP0, it will set up the pins for that and leave McBSP pins as they were, but= other board might use McBSP1 and not use McASP0, there you will have pincontr= ol for McBSP1. > Or did I miss something? >=20 >> >>> + >; >>> + }; >>> }; >>> edma0: edma@01c00000 { >>> compatible =3D "ti,edma3-tpcc"; >>> @@ -335,6 +352,32 @@ >>> <&edma0 0 1>; >>> dma-names =3D "tx", "rx"; >>> }; >>> + >>> + mcbsp0: mcbsp@1d10000 { >>> + compatible =3D "ti,da850-mcbsp-audio"; >>> + reg =3D <0x00110000 0x1000>, >>> + <0x00310000 0x1000>; >>> + reg-names =3D "mpu", "dat"; >>> + interrupts =3D <97 98>; >>> + interrupts-names =3D "rx", "tx"; >>> + dmas =3D <&edma0 3 >>> + &edma0 2>; >> This will not work since the eDMA now has the new binding in use, yo= u need to >> have: >> dmas =3D <&edma0 3 1>, >> <&edma0 2 1>; >> >> McBSP should also select the higher priority TPTC as the McASP does. > Absolutely, you are right! I still use the old DMA phandles. I will c= orrect that. >=20 > Petr --=20 P=E9ter -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html