From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration Date: Wed, 31 Aug 2016 15:33:47 +0200 Message-ID: <5709554.y3Mq6my3Uz@wuerfel> References: <1472645613-5362-1-git-send-email-k.kozlowski@samsung.com> <6113443.1q3Xq4YM82@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Mark Rutland , Kukjin Kim , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , Tomasz Figa , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz List-Id: devicetree@vger.kernel.org On Wednesday, August 31, 2016 3:07:00 PM CEST Krzysztof Kozlowski wrote: > > Ok, sounds reasonable. I want to convert also older platforms S3C (drive > strengths and pull up/down differ) and arm64 SoC: Exynos7. For the > latter the problem is there is no common place for sharing DTS, except > the headers. However this does not really belong to headers. I guess > some level of duplication might be still exist. We have stuff in the headers that belongs way less there, so I wouldn't mind, but having a separate set of definitions for arm64 also isn't a problem at all. > > I think overall, a better solution would have been to define the > > constants globally (shared with non-exynos) to start with, > > and have the driver translate generic numbers into vendor > > specific ones. Obviously it's too late for that now. > > We could extend driver by adding new bindings accepting generic numbers > (and still backward compatible) but this looks like an overkill. Agreed, that would only make things more confusing, not less. Arnd