From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH] of: Add generic handling for hardware incomplete fail state Date: Tue, 12 Apr 2016 15:39:30 -0700 Message-ID: <570D7922.5020206@gmail.com> References: <1460486275-12256-1-git-send-email-tony@atomide.com> <570D56FE.2070408@gmail.com> Reply-To: frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <570D56FE.2070408-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: Tony Lindgren , Grant Likely , Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Nishanth Menon , Tero Kristo , Tom Rini List-Id: devicetree@vger.kernel.org On 4/12/2016 1:13 PM, Frank Rowand wrote: > Hi Tony, < snip > > With that change, the bulk of your patch looks good, with > minor changes: > > __of_device_is_available() would not need to change. > > __of_device_is_incomplete() would change to check the new > boolean property. (And I would suggest renaming it to > something that conveys it is ok to power manage the > device, but do not do anything else to the device.) > > -Frank One more thought... Are there multiple drivers that need to follow this pattern, or just one at the moment? If just one driver, then I would suggest open-coding accessing the property in the probe routine instead of adding the helper functions. If more drivers appear with the same pattern then the helper functions could be added. -Frank -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html