From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: tony@atomide.com, bcousson@baylibre.com, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: omap3-n900: Specify peripherals LDO regulators initial mode
Date: Sun, 17 Apr 2016 09:14:08 +0300 [thread overview]
Message-ID: <571329B0.9060503@gmail.com> (raw)
In-Reply-To: <20160417000536.GA1124@earth>
On 17.04.2016 03:05, Sebastian Reichel wrote:
> Hi Ivo,
>
> On Sat, Apr 16, 2016 at 09:37:23AM +0300, Ivaylo Dimitrov wrote:
>> Without that, regulators are left in the mode last set by the bootloader or
>> by the kernel the device was rebooted from. This leads to various problems
>> like non-working peripherals.
>>
>> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
>> ---
>> arch/arm/boot/dts/omap3-n900.dts | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
>> index b3c26a9..1bb36e2 100644
>> --- a/arch/arm/boot/dts/omap3-n900.dts
>> +++ b/arch/arm/boot/dts/omap3-n900.dts
>> @@ -329,6 +329,7 @@
>> regulator-name = "V28";
>> regulator-min-microvolt = <2800000>;
>> regulator-max-microvolt = <2800000>;
>> + regulator-initial-mode = <0x0e>;
>> regulator-always-on; /* due to battery cover sensor */
>> };
>
> I think this should either get an additional
> comment like /* MODE_NORMAL */ or implemented
According to the TRM, this is 'ACTIVE state', but that does not fit in
the regulator framework terminology.
> using a define and a TWL4030_REGULATOR_MODE_NORMAL
> constant to keep the *.dts easily readable.
We already have RES_STATE_ACTIVE defined in linux/i2c/twl.h, is there a
way to include that in a dts?
Ivo
next prev parent reply other threads:[~2016-04-17 6:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 6:37 [PATCH] ARM: dts: omap3-n900: Specify peripherals LDO regulators initial mode Ivaylo Dimitrov
2016-04-17 0:05 ` Sebastian Reichel
2016-04-17 6:14 ` Ivaylo Dimitrov [this message]
[not found] ` <571329B0.9060503-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-17 12:29 ` Sebastian Reichel
2016-04-17 14:29 ` [PATCH v1] " Ivaylo Dimitrov
2016-04-18 5:11 ` Sebastian Reichel
[not found] ` <1460903363-2197-1-git-send-email-ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-19 21:18 ` Javier Martinez Canillas
2016-04-24 10:08 ` Pavel Machek
2016-04-26 17:14 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571329B0.9060503@gmail.com \
--to=ivo.g.dimitrov.75@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).