From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Kulhavy Subject: Re: [PATCH v2 2/6] ASoC: Davinci: McBSP: add device tree support for McBSP Date: Mon, 18 Apr 2016 12:24:54 +0200 Message-ID: <5714B5F6.9@barix.com> References: <1460375117-4311-1-git-send-email-petr@barix.com> <1460375117-4311-3-git-send-email-petr@barix.com> <5710B516.2000006@ti.com> <5714A864.5050505@barix.com> <5714B469.1040408@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5714B469.1040408@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Peter Ujfalusi , nsekhar@ti.com, khilman@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, devicetree@vger.kernel.org Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, robh+dt@kernel.org, galak@codeaurora.org List-Id: devicetree@vger.kernel.org On 18.04.2016 12:18, Peter Ujfalusi wrote: > On 04/18/16 12:27, Petr Kulhavy wrote: > >> Or what do you think the pdata should carry? > Good question. Since the driver itself does not care about pdata I would > remove it. On the other hand if you implement the FIFO handling you will need > pdata for legacy mode to select the FIFO threshold. > Currently there is one pdata structure for legacy mode used by the McASP, > McBSP and the Voice Codec. It contains mixed options applicable for all and > some which applicable only for one of the drivers... > I think if we want to make things clean and neat we would aim to have separate > pdata for each of the drivers. > > I would probably drop the current pdata for McBSP and when I see what data I > need for the driver later I would create one for the McBSP only. > Thanks, Peter. I agree with you. I don't have the time to implement the FIFO now, so it makes sense to drop the pdata for now and add a dedicated one if needed later. Shall I remove the pdata also from the EVK legacy board drivers? I'm going to prepare another patch set. Cheers Petr