From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Sperl Subject: Re: [PATCH V2 2/3] dmaengine: bcm2835: use platform_get_irq_byname Date: Wed, 20 Apr 2016 13:06:15 +0200 Message-ID: <571762A7.7000005@martin.sperl.org> References: <1460381349-14408-1-git-send-email-kernel@martin.sperl.org> <1460381349-14408-3-git-send-email-kernel@martin.sperl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: Rob Herring , Mark Rutland , Stephen Warren , Lee Jones , Eric Anholt , Russell King , Vinod Koul , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 20.04.2016 08:51, Geert Uytterhoeven wrote: > On Mon, Apr 11, 2016 at 3:29 PM, wrote: >> From: Martin Sperl >> >> Use platform_get_irq_byname to allow for correct mapping of >> interrupts to dma channels. >> >> The currently implemented device tree is unfortunately >> implemented with the wrong assumption, that each dma-channel >> has its own dma channel, but dma-irq 11 is handling >> dma-channel 11-14 and dma-irq 12 is actually a "catch all" >> interrupt. >> >> So here we use the byname variant and require that interrupts >> are explicitly named via the interrupts-name property in the > > interrupt-names Vinod has just merged this patch - do you want me to submit another to correct those? > You're not explicitly looking for "dma-shared-all" for that? > You might as well just declare a single unnamed interrupt in the bindings. dma-shared-all is unfortunately an interrupt-line that triggers for interrupt-channels 0-15 and that includes the dma channels that are owned by the firmware. It is there mostly to document the interrupt-line (which is there in the existing device tree files - it is not used. Martin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html