From: Scott Branden <scott.branden@broadcom.com>
To: Luke Starrett <luke.starrett@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>
Cc: devicetree@vger.kernel.org,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] arm64: dts: NS2 secondary core enablement via PSCI
Date: Wed, 20 Apr 2016 12:05:14 -0700 [thread overview]
Message-ID: <5717D2EA.4030900@broadcom.com> (raw)
In-Reply-To: <1461174002-18178-1-git-send-email-luke.starrett@broadcom.com>
Looks good while we are using PSCI-1.0
Acked-by: Scott Branden <scott.branden@broadcom.com>
On 16-04-20 10:40 AM, Luke Starrett wrote:
> Declare PSCI-1.0 node and enable CPU_ON method via PSCI. Spin-table
> memreserve has been removed as well as syscon based reset, as PSCI-1.0
> expects reset implementation in firmware.
>
> Signed-off-by: Luke Starrett <luke.starrett@broadcom.com>
> ---
>
> Changes from v1:
> - No code changes, adding missing reviewers to CC list
>
> arch/arm64/boot/dts/broadcom/ns2.dtsi | 31 +++++++++----------------------
> 1 file changed, 9 insertions(+), 22 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi b/arch/arm64/boot/dts/broadcom/ns2.dtsi
> index 123cd9c..ec68ec1 100644
> --- a/arch/arm64/boot/dts/broadcom/ns2.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/ns2.dtsi
> @@ -33,8 +33,6 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/bcm-ns2.h>
>
> -/memreserve/ 0x84b00000 0x00000008;
> -
> / {
> compatible = "brcm,ns2";
> interrupt-parent = <&gic>;
> @@ -49,8 +47,7 @@
> device_type = "cpu";
> compatible = "arm,cortex-a57", "arm,armv8";
> reg = <0 0>;
> - enable-method = "spin-table";
> - cpu-release-addr = <0 0x84b00000>;
> + enable-method = "psci";
> next-level-cache = <&CLUSTER0_L2>;
> };
>
> @@ -58,8 +55,7 @@
> device_type = "cpu";
> compatible = "arm,cortex-a57", "arm,armv8";
> reg = <0 1>;
> - enable-method = "spin-table";
> - cpu-release-addr = <0 0x84b00000>;
> + enable-method = "psci";
> next-level-cache = <&CLUSTER0_L2>;
> };
>
> @@ -67,8 +63,7 @@
> device_type = "cpu";
> compatible = "arm,cortex-a57", "arm,armv8";
> reg = <0 2>;
> - enable-method = "spin-table";
> - cpu-release-addr = <0 0x84b00000>;
> + enable-method = "psci";
> next-level-cache = <&CLUSTER0_L2>;
> };
>
> @@ -76,8 +71,7 @@
> device_type = "cpu";
> compatible = "arm,cortex-a57", "arm,armv8";
> reg = <0 3>;
> - enable-method = "spin-table";
> - cpu-release-addr = <0 0x84b00000>;
> + enable-method = "psci";
> next-level-cache = <&CLUSTER0_L2>;
> };
>
> @@ -86,6 +80,11 @@
> };
> };
>
> + psci {
> + compatible = "arm,psci-1.0";
> + method = "smc";
> + };
> +
> timer {
> compatible = "arm,armv8-timer";
> interrupts = <GIC_PPI 13 (GIC_CPU_MASK_RAW(0xff) |
> @@ -252,18 +251,6 @@
> mmu-masters;
> };
>
> - crmu: crmu@65024000 {
> - compatible = "syscon";
> - reg = <0x65024000 0x100>;
> - };
> -
> - reboot@65024000 {
> - compatible ="syscon-reboot";
> - regmap = <&crmu>;
> - offset = <0x90>;
> - mask = <0xfffffffd>;
> - };
> -
> gic: interrupt-controller@65210000 {
> compatible = "arm,gic-400";
> #interrupt-cells = <3>;
>
next prev parent reply other threads:[~2016-04-20 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 17:40 [PATCH v2 1/1] arm64: dts: NS2 secondary core enablement via PSCI Luke Starrett
2016-04-20 19:05 ` Scott Branden [this message]
[not found] ` <1461174002-18178-1-git-send-email-luke.starrett-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-04-22 19:05 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5717D2EA.4030900@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke.starrett@broadcom.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).