From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>,
linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-soc@vger.kernel.org
Subject: Re: [PATCH v2 05/13] ARM: dts: db600c: add pmic regulator supplies
Date: Fri, 22 Apr 2016 10:11:55 +0100 [thread overview]
Message-ID: <5719EADB.9090704@linaro.org> (raw)
In-Reply-To: <571682A1.9010000@codeaurora.org>
On 19/04/16 20:10, Stephen Boyd wrote:
> On 04/12/2016 02:33 AM, Srinivas Kandagatla wrote:
>> This patch adds pmic regulator supplies connected on the board.
>> Rest of the invidual regulators would be added as and when required by
>> the devices.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>> arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts | 62 +++++++++++++++++++++++++
>> 1 file changed, 62 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts b/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts
>> index 57d4500..6695b00 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-arrow-db600c.dts
>> @@ -9,7 +9,69 @@
>> serial1 = &gsbi1_serial;
>> };
>>
>> + regulators {
>> + compatible = "simple-bus";
>> + vph: regulator-fixed@1 {
>> + compatible = "regulator-fixed";
>> + regulator-min-microvolt = <4500000>;
>> + regulator-max-microvolt = <4500000>;
>> + regulator-name = "VPH";
>> + regulator-type = "voltage";
>> + regulator-boot-on;
>> + };
>> + };
>
> Just curious why we added the vph supply? Is that for some framework
> requirement? We haven't done this on other boards, although we probably
> should if there's a good reason for it.
This is an on board 12V TO 4.5V @5.5A DC/DC convertor for PMIC VPH
power. Yep we should do something similar on the other boards too.
Without this probably you would notice some error messages from
rpm_regulators about missing supply nodes.
thanks,
srini
>
next prev parent reply other threads:[~2016-04-22 9:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 9:33 [PATCH v2 00/13] ARM: dts: Add DB600c support Srinivas Kandagatla
2016-04-12 9:33 ` [PATCH v2 01/13] ARM: dts: apq8064: fix the pinctrls for i2c and spi Srinivas Kandagatla
2016-04-12 9:33 ` [PATCH v2 02/13] ARM: dts: apq8064: add support to gsbi1 uart Srinivas Kandagatla
2016-04-12 9:33 ` [PATCH v2 03/13] ARM: dts: apq8064: add gsbi7 i2c support Srinivas Kandagatla
2016-04-12 9:33 ` [PATCH v2 04/13] ARM: dts: db600c: add board support with serial Srinivas Kandagatla
2016-04-12 9:33 ` [PATCH v2 05/13] ARM: dts: db600c: add pmic regulator supplies Srinivas Kandagatla
2016-04-19 19:10 ` Stephen Boyd
2016-04-22 9:11 ` Srinivas Kandagatla [this message]
2016-04-12 9:33 ` [PATCH v2 06/13] ARM: dts: db600c: Add eMMC and SD card support Srinivas Kandagatla
2016-04-12 9:33 ` [PATCH v2 07/13] ARM: dts: db600c: add usb support Srinivas Kandagatla
2016-04-12 9:33 ` [PATCH v2 08/13] ARM: dts: db600c: add pcie support Srinivas Kandagatla
2016-04-12 9:33 ` [PATCH v2 09/13] ARM: dts: db600c: add on board sata support Srinivas Kandagatla
2016-04-12 9:33 ` [PATCH v2 10/13] ARM: dts: db600c: Add on board leds support Srinivas Kandagatla
2016-04-12 9:34 ` [PATCH v2 11/13] ARM: dts: db600c: add i2c support Srinivas Kandagatla
2016-04-12 9:34 ` [PATCH v2 12/13] ARM: dts: db600c: add spi support Srinivas Kandagatla
2016-04-12 9:34 ` [PATCH v2 13/13] ARM: dts: db600c: add support to magnetometer Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5719EADB.9090704@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=andy.gross@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).