devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Wahren <info@lategoodbye.de>
To: kernelnewbies@kernelnewbies.org,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "Jörg Krause" <joerg.krause@embedded.rocks>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <kernel@pengutronix.de>
Subject: strange dtc errors after adding sram node
Date: Sat, 23 Apr 2016 09:46:07 +0200	[thread overview]
Message-ID: <571B283F.8010707@lategoodbye.de> (raw)

Hi,

i want to add an sram node to arch/arm/boot/dts/imx28.dtsi. According to 
the reference manual [1] the On-Chip RAM is connected to AHB, start 
address 0 and has a size of 128 KB.

So i modified the imx28.dtsi based on the patch below. Unfortunately the 
dtc give me some strang errors:

ERROR (duplicate_label): Duplicate label 'mac0' on 
/ahb@80080000/ethernet@800f0000 and /ahb@00000000/ethernet@800f0000
ERROR: Input tree has errors, aborting (use -f to force output)

What's wrong with my patch or does it reveal another issue?

Regards
Stefan

[1] - http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf
i.MX28 Applications Processor Reference Manual, Rev. 2, 08/2013
Chapter 4.1 Memory Map Overview

-------------------------->8---------------------------------------
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -1311,13 +1311,18 @@
  		};
  	};

-	ahb@80080000 {
+	ahb@00000000 {
  		compatible = "simple-bus";
  		#address-cells = <1>;
  		#size-cells = <1>;
-		reg = <0x80080000 0x80000>;
+		reg = <0x00000000 0x20000>, <0x80080000 0x80000>;
  		ranges;

+		ocram: sram@00000000 {
+			compatible = "mmio-sram";
+			reg = <0x00000000 0x20000>;
+		};
+
  		usb0: usb@80080000 {
  			compatible = "fsl,imx28-usb", "fsl,imx27-usb";
  			reg = <0x80080000 0x10000>;

             reply	other threads:[~2016-04-23  7:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-23  7:46 Stefan Wahren [this message]
     [not found] ` <571B283F.8010707-saaNCTdWVBT7BZbvpMY5sg@public.gmane.org>
2016-04-23  8:18   ` strange dtc errors after adding sram node Jörg Krause
     [not found]     ` <1461399514.2205.20.camel-L1vi/lXTdtsfGbAt6QbQcg@public.gmane.org>
2016-04-23 10:33       ` Jörg Krause
     [not found]         ` <1461407589.1986.3.camel-L1vi/lXTdtsfGbAt6QbQcg@public.gmane.org>
2016-04-25  6:04           ` Stefan Wahren
     [not found]             ` <571DB385.9010305-saaNCTdWVBT7BZbvpMY5sg@public.gmane.org>
2016-04-25 13:06               ` Arnd Bergmann
2016-04-27 20:16                 ` Stefan Wahren
     [not found]                   ` <57211E2A.5060807-saaNCTdWVBT7BZbvpMY5sg@public.gmane.org>
2016-04-27 20:20                     ` Arnd Bergmann
2016-04-23  8:24   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571B283F.8010707@lategoodbye.de \
    --to=info@lategoodbye.de \
    --cc=devicetree@vger.kernel.org \
    --cc=joerg.krause@embedded.rocks \
    --cc=kernel@pengutronix.de \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).