devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars Persson <lars.persson-VrBV9hrLPhE@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Lars Persson <larper-VrBV9hrLPhE@public.gmane.org>
Cc: linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	g.liakhovetski-Mmb7MZpHnFY@public.gmane.org,
	ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [PATCH v4 1/3] mmc: dt: usdhi6rol0: add optional pinctrl binding
Date: Tue, 26 Apr 2016 14:23:16 +0200	[thread overview]
Message-ID: <571F5DB4.7090303@axis.com> (raw)
In-Reply-To: <20160422202733.GA11270@rob-hp-laptop>



On 04/22/2016 10:27 PM, Rob Herring wrote:
> On Thu, Apr 21, 2016 at 03:55:42PM +0200, Lars Persson wrote:
>> Add a pinctrl binding to specify different pin settings for high speed
>> modes and UHS modes.
>>
>> Signed-off-by: Lars Persson <larper-VrBV9hrLPhE@public.gmane.org>
>> ---
>>   Documentation/devicetree/bindings/mmc/usdhi6rol0.txt | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>> index 8babdaa..6d1b797 100644
>> --- a/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>> +++ b/Documentation/devicetree/bindings/mmc/usdhi6rol0.txt
>> @@ -12,6 +12,12 @@ Optional properties:
>>
>>   - vmmc-supply:	a phandle of a regulator, supplying Vcc to the card
>>   - vqmmc-supply:	a phandle of a regulator, supplying VccQ to the card
>> +- pinctrl-names: Can contain a "default" entry and a "state_uhs"
>
> Don't use underscores. Just "uhs" should be sufficient, right?

I do not object to this, but for consistency it seems better with 
state_uhs that existing bindings use.

>
>> +                 entry. The state_uhs entry is used together with the default
>> +                 entry when the board requires distinct settings for UHS speeds.
>> +
>> +- pinctrl-N: One property for each name listed in pinctrl-names, see
>> +             ../pinctrl/pinctrl-bindings.txt.
>>
>>   Additionally any standard mmc bindings from mmc.txt can be used.
>>
>> --
>> 2.1.4
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-04-26 12:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-21 13:55 [PATCH v4 0/3] mmc: usdhi6rol0: UHS support Lars Persson
     [not found] ` <cover.1461246772.git.larper-VrBV9hrLPhE@public.gmane.org>
2016-04-21 13:55   ` [PATCH v4 1/3] mmc: dt: usdhi6rol0: add optional pinctrl binding Lars Persson
2016-04-22 20:27     ` Rob Herring
2016-04-26 12:23       ` Lars Persson [this message]
2016-04-26 13:19         ` Rob Herring
2016-04-21 13:55 ` [PATCH v4 2/3] mmc: usdhi6rol0: add support for UHS modes Lars Persson
2016-04-22 12:53   ` Ulf Hansson
2016-04-21 13:55 ` [PATCH v4 3/3] mmc: usdhi6rol0: add pinctrl to set pin drive strength Lars Persson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571F5DB4.7090303@axis.com \
    --to=lars.persson-vrbv9hrlphe@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=g.liakhovetski-Mmb7MZpHnFY@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=larper-VrBV9hrLPhE@public.gmane.org \
    --cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).