From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: srinivas.kandagatla@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v2 2/2] nvmem: lan9662-otp: add support.
Date: Fri, 26 Aug 2022 09:43:03 +0300 [thread overview]
Message-ID: <571db5f6-1221-f8e0-1cc6-ff84dcf83cf9@linaro.org> (raw)
In-Reply-To: <20220825204041.1485731-3-horatiu.vultur@microchip.com>
On 25/08/2022 23:40, Horatiu Vultur wrote:
> +static int lan9662_otp_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
> + struct nvmem_device *nvmem;
> + struct lan9662_otp *otp;
> +
> + otp = devm_kzalloc(&pdev->dev, sizeof(*otp), GFP_KERNEL);
> + if (!otp)
> + return -ENOMEM;
> +
> + otp->dev = dev;
> + otp->base = devm_platform_ioremap_resource(pdev, 0);
> + if (IS_ERR(otp->base))
> + return PTR_ERR(otp->base);
> +
> + otp_config.priv = otp;
> + otp_config.dev = dev;
> +
> + nvmem = devm_nvmem_register(dev, &otp_config);
> +
> + return PTR_ERR_OR_ZERO(nvmem);
> +}
> +
> +static const struct of_device_id lan9662_otp_match[] = {
> + { .compatible = "microchip,lan9662-otp", },
> + { .compatible = "microchip,lan9668-otp", },
Why do you need two compatibles here? Your bindings are saying only one
is needed...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-26 6:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 20:40 [PATCH v2 0/2] nvmem: lan9662-otpc: add support Horatiu Vultur
2022-08-25 20:40 ` [PATCH v2 1/2] dt-bindings: lan9662-otpc: document Lan9662 OTPC Horatiu Vultur
2022-08-26 6:42 ` Krzysztof Kozlowski
2022-08-26 7:31 ` Horatiu Vultur
2022-08-26 17:37 ` Krzysztof Kozlowski
2022-08-29 6:35 ` Horatiu Vultur
2022-08-30 10:10 ` Krzysztof Kozlowski
2022-08-26 16:05 ` Rob Herring
2022-08-25 20:40 ` [PATCH v2 2/2] nvmem: lan9662-otp: add support Horatiu Vultur
2022-08-26 6:43 ` Krzysztof Kozlowski [this message]
2022-08-30 12:08 ` Srinivas Kandagatla
2022-08-30 20:07 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571db5f6-1221-f8e0-1cc6-ff84dcf83cf9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).