From: Sinan Kaya <okaya@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org,
jcm@redhat.com, eric.auger@linaro.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, vikrams@codeaurora.org,
marc.zyngier@arm.com, linux-arm-msm@vger.kernel.org,
vinod.koul@intel.com, agross@codeaurora.org,
shankerd@codeaurora.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH V4 0/2] vfio, platform: add ACPI support
Date: Tue, 3 May 2016 16:46:29 -0400 [thread overview]
Message-ID: <57290E25.7010501@codeaurora.org> (raw)
In-Reply-To: <3322250.xDEDujoeAM@wuerfel>
On 5/3/2016 4:12 PM, Arnd Bergmann wrote:
> On Sunday 01 May 2016 17:07:50 Sinan Kaya wrote:
>> The patchset makes three different changes.
>> 1. Add support for probing ACPI platform devices.
>> 2. Add support for ACPI _RST method support during reset
>> 3. Make reset driver a requirement by default with an optional
>> kernel command line override
>
> Looks nice, thanks for rewriting this!
>
> For future submissions, it would help to have a list of changes
> compared to the previous versions a the patch set in the cover
> letter to help reviewers, but this time my memory was still fresh
> enough.
>
> Arnd
>
Sure, will do. I asked Rafael to review the ACPI code.
+ ret = vfio_platform_call_reset(vdev);
This is the only problem I'm seeing in the code. I tested the ACPI path only.
I'm wondering if Eric could test the device tree version.
+ if (ret)
+ goto err_irq;
I'll get rid of this line on the first patch and move it to second
patch along with reset_required check.
--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-05-03 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-01 21:07 [PATCH V4 0/2] vfio, platform: add ACPI support Sinan Kaya
2016-05-01 21:07 ` [PATCH V4 1/2] vfio, platform: add support for ACPI during probe and reset Sinan Kaya
2016-05-09 15:47 ` Eric Auger
2016-05-09 19:45 ` Sinan Kaya
2016-05-01 21:07 ` [PATCH V4 2/2] vfio, platform: make reset driver a requirement by default Sinan Kaya
2016-05-03 20:12 ` [PATCH V4 0/2] vfio, platform: add ACPI support Arnd Bergmann
2016-05-03 20:46 ` Sinan Kaya [this message]
2016-05-06 18:35 ` Sinan Kaya
2016-05-06 19:54 ` Rafael J. Wysocki
2016-05-06 19:52 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57290E25.7010501@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=arnd@arndb.de \
--cc=cov@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=eric.auger@linaro.org \
--cc=jcm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=shankerd@codeaurora.org \
--cc=timur@codeaurora.org \
--cc=vikrams@codeaurora.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).