From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node
Date: Wed, 4 May 2016 10:25:51 +0800 [thread overview]
Message-ID: <57295DAF.1050800@nvidia.com> (raw)
In-Reply-To: <20160503152111.GC19539-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
On 2016年05月03日 23:21, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Tue, May 03, 2016 at 05:09:37PM +0800, Wei Ni wrote:
>> This patch changes the compatible of Tegra132 fuse node
>> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse".
>> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for
>> Tegra132, the fuse driver can't find the corresponding node.
>
> Okay, that's not really a good reason to modify the DTS. What we should
> do instead is make sure that the OF table contains the entry on Tegra132
> builds. Unless the IP block really is different and Tegra124 and
> Tegra132 aren't compatible in this regard after all.
>
> In the latter case the commit message should reflect the real reason.
Hi Thierry,
The fuse driver fuse-tegra.c has following OF table:
#ifdef CONFIG_ARCH_TEGRA_132_SOC
{ .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc },
#endif
#ifdef CONFIG_ARCH_TEGRA_124_SOC
{ .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc },
#endif
It defined "nvidia,tegra124-efuse" under CONFIG_ARCH_TEGRA_124_SOC, so if we
don't change the DTS file, we should change it as:
-#ifdef CONFIG_ARCH_TEGRA_132_SOC
- { .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc },
-#endif
-#ifdef CONFIG_ARCH_TEGRA_124_SOC
+#if defined CONFIG_ARCH_TEGRA_124_SOC || defined CONFIG_ARCH_TEGRA_132_SOC
{ .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc },
#endif
#ifdef CONFIG_ARCH_TEGRA_114_SOC
I will send it out.
>
> Thierry
>
> * Unknown Key
> * 0x7F3EB3A1
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-04 2:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 9:09 [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node Wei Ni
2016-05-03 15:21 ` Thierry Reding
[not found] ` <20160503152111.GC19539-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-05-04 2:25 ` Wei Ni [this message]
[not found] ` <57295DAF.1050800-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-04 7:32 ` Wei Ni
-- strict thread matches above, loose matches on Subject: below --
2016-05-03 9:32 Wei Ni
2016-05-03 10:11 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57295DAF.1050800@nvidia.com \
--to=wni-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).