From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Ni Subject: Re: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node Date: Wed, 4 May 2016 10:25:51 +0800 Message-ID: <57295DAF.1050800@nvidia.com> References: <1462266577-951-1-git-send-email-wni@nvidia.com> <20160503152111.GC19539@ulmo.ba.sec> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160503152111.GC19539-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 2016=E5=B9=B405=E6=9C=8803=E6=97=A5 23:21, Thierry Reding wrote: > * PGP Signed by an unknown key >=20 > On Tue, May 03, 2016 at 05:09:37PM +0800, Wei Ni wrote: >> This patch changes the compatible of Tegra132 fuse node >> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse". >> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for >> Tegra132, the fuse driver can't find the corresponding node. >=20 > Okay, that's not really a good reason to modify the DTS. What we shou= ld > do instead is make sure that the OF table contains the entry on Tegra= 132 > builds. Unless the IP block really is different and Tegra124 and > Tegra132 aren't compatible in this regard after all. >=20 > In the latter case the commit message should reflect the real reason. Hi Thierry, The fuse driver fuse-tegra.c has following OF table: #ifdef CONFIG_ARCH_TEGRA_132_SOC { .compatible =3D "nvidia,tegra132-efuse", .data =3D &tegra124_= fuse_soc }, #endif #ifdef CONFIG_ARCH_TEGRA_124_SOC { .compatible =3D "nvidia,tegra124-efuse", .data =3D &tegra124_= fuse_soc }, #endif It defined "nvidia,tegra124-efuse" under CONFIG_ARCH_TEGRA_124_SOC, so = if we don't change the DTS file, we should change it as: -#ifdef CONFIG_ARCH_TEGRA_132_SOC - { .compatible =3D "nvidia,tegra132-efuse", .data =3D &tegra124_= fuse_soc }, -#endif -#ifdef CONFIG_ARCH_TEGRA_124_SOC +#if defined CONFIG_ARCH_TEGRA_124_SOC || defined CONFIG_ARCH_TEGRA_132= _SOC { .compatible =3D "nvidia,tegra124-efuse", .data =3D &tegra124_= fuse_soc }, #endif #ifdef CONFIG_ARCH_TEGRA_114_SOC I will send it out. >=20 > Thierry >=20 > * Unknown Key > * 0x7F3EB3A1 >=20 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html