From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David.Wu" Subject: Re: [PATCH v7 2/9] i2c: rk3x: use struct "rk3x_i2c_calced_timings" Date: Fri, 6 May 2016 10:19:13 +0800 Message-ID: <572BFF21.6060500@rock-chips.com> References: <1462371194-5809-1-git-send-email-david.wu@rock-chips.com> <1462371194-5809-3-git-send-email-david.wu@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-i2c-owner@vger.kernel.org To: Doug Anderson Cc: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Wolfram Sang , Rob Herring , Andy Shevchenko , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Brian Norris , David Riley , Tao Huang , Lin Huang , Jianqun Xu , Chris , Eddie Cai , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org Hi Doug, =E5=9C=A8 2016/5/6 6:55, Doug Anderson =E5=86=99=E9=81=93: > David, > > On Wed, May 4, 2016 at 7:13 AM, David Wu wr= ote: >> Signed-off-by: David Wu > > Usually folks like a description and not just a subject line. I'd ad= d > a description like: > > The "div_high" and "div_low" values are always used together. Group = them > into a structure to make it easier to pass them both around. This > structure also provides a place for future calculated timings. > Okay, i will add it in next version, thanks. >> --- >> Change in v7: >> - none >> >> drivers/i2c/busses/i2c-rk3x.c | 55 +++++++++++++++++++++++++------= ------------ >> 1 file changed, 32 insertions(+), 23 deletions(-) > > Other than the description, I think this looks fine. > > IMHO this can be applied any time independent of any earlier patches. > > Reviewed-by: Douglas Anderson > > >