[PATCH] ARM: dts: dra7xx: Fix compatible string for PCF8575 chip

[PATCH] ARM: dts: dra7xx: Fix compatible string for PCF8575 chip

[Roger Quadros]

The boards use a TI variant of the PCF8575 so specify that
in the compatible string.

Signed-off-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
---
 arch/arm/boot/dts/dra7-evm.dts          | 6 +++---
 arch/arm/boot/dts/dra72-evm-common.dtsi | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
index d272cf1..4fb0ff4 100644
--- a/arch/arm/boot/dts/dra7-evm.dts
+++ b/arch/arm/boot/dts/dra7-evm.dts
@@ -556,7 +556,7 @@
 	};
 
 	pcf_lcd: gpio@20 {
-		compatible = "nxp,pcf8575";
+		compatible = "ti,pcf8575", "nxp,pcf8575";
 		reg = <0x20>;
 		gpio-controller;
 		#gpio-cells = <2>;
@@ -567,7 +567,7 @@
 	};
 
 	pcf_gpio_21: gpio@21 {
-		compatible = "nxp,pcf8575";
+		compatible = "ti,pcf8575", "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;
@@ -601,7 +601,7 @@
 	clock-frequency = <400000>;
 
 	pcf_hdmi: gpio@26 {
-		compatible = "nxp,pcf8575";
+		compatible = "ti,pcf8575", "nxp,pcf8575";
 		reg = <0x26>;
 		gpio-controller;
 		#gpio-cells = <2>;
diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
index 2c88050..90a827d 100644
--- a/arch/arm/boot/dts/dra72-evm-common.dtsi
+++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
@@ -408,7 +408,7 @@
 	};
 
 	pcf_gpio_21: gpio@21 {
-		compatible = "nxp,pcf8575";
+		compatible = "ti,pcf8575", "nxp,pcf8575";
 		reg = <0x21>;
 		lines-initial-states = <0x1408>;
 		gpio-controller;
@@ -440,7 +440,7 @@
 	clock-frequency = <400000>;
 
 	pcf_hdmi: pcf8575@26 {
-		compatible = "nxp,pcf8575";
+		compatible = "ti,pcf8575", "nxp,pcf8575";
 		reg = <0x26>;
 		gpio-controller;
 		#gpio-cells = <2>;
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: dra7xx: Fix compatible string for PCF8575 chip

[Tony Lindgren]

* Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org> [160425 05:55]:
> The boards use a TI variant of the PCF8575 so specify that
> in the compatible string.

Applying into omap-for-v4.6/dt thanks.

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: dra7xx: Fix compatible string for PCF8575 chip

[Ben Hutchings]

On Mon, 2016-04-25 at 15:53 +0300, Roger Quadros wrote:
> The boards use a TI variant of the PCF8575 so specify that
> in the compatible string.
> 
> Signed-off-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
[...]

1. This compatible string is still not documented (AFAIK).
2. As I understand it, TI is a second source for this NXP-designed chip,
i.e. it manufactures chips with identical logic (not clones) under
license.  They should not be distinguishable in software.
3. For the same reason, there is no guarantee that the board
manufacturer won't populate boards with PCF8575 chips from the other
source in future.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: dra7xx: Fix compatible string for PCF8575 chip

[Sebastian Andrzej Siewior]

On 05/04/2016 08:23 PM, Ben Hutchings wrote:
> On Mon, 2016-04-25 at 15:53 +0300, Roger Quadros wrote:
>> The boards use a TI variant of the PCF8575 so specify that
>> in the compatible string.
>>
>> Signed-off-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
> [...]
> 
> 1. This compatible string is still not documented (AFAIK).
> 2. As I understand it, TI is a second source for this NXP-designed chip,
> i.e. it manufactures chips with identical logic (not clones) under
> license.  They should not be distinguishable in software.

Mistakes don't happen on purpose.

> 3. For the same reason, there is no guarantee that the board
> manufacturer won't populate boards with PCF8575 chips from the other
> source in future.

If it is a redesign it is likely that they replace more than just one
part.

> 
> Ben.
> 
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html