From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock Date: Mon, 9 May 2016 13:28:14 +0100 Message-ID: <5730825E.5030101@linaro.org> References: <1461173177-11930-1-git-send-email-van.freenix@gmail.com> <1461173177-11930-3-git-send-email-van.freenix@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1461173177-11930-3-git-send-email-van.freenix-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peng Fan , shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Thanks for the Ping, I totally missed this thread. On 20/04/16 18:26, Peng Fan wrote: > Before access ocotp nvmem area, the clock should be enabled. > Or, `hexdump nvmem` will hang the system. So, use such flow: > " > 1. clock_enable_prepare > 2. read nvmem ocotp area > 3. clock_disable_unprepare > " > > Signed-off-by: Peng Fan > Cc: Srinivas Kandagatla > Cc: Maxime Ripard > Cc: Shawn Guo > --- > > V2: > Follow Fabio's comments, check return value of clk_prepare_enable > > drivers/nvmem/imx-ocotp.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) Changes to the driver looks good to me, Only one comment, As the clock property is now made mandatory, you should update the dt-bindings with this info too. thanks, srini -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html