From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Jon Mason <jon.mason@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>
Cc: bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: NS2: Add all of the UARTs
Date: Thu, 12 May 2016 14:16:46 +0800 [thread overview]
Message-ID: <57341FCE.6050403@huawei.com> (raw)
In-Reply-To: <1463007369-13071-1-git-send-email-jonmason@broadcom.com>
On 2016/5/12 6:56, Jon Mason wrote:
> Add all of the UARTs present on NS2 and enable them in the SVK device
> tree file. Also, do some magic to make sure that uart3 is discovered as
> ttyS0 (as that is the console UART).
>
> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> ---
> arch/arm64/boot/dts/broadcom/ns2-svk.dts | 16 ++++++++++++++++
> arch/arm64/boot/dts/broadcom/ns2.dtsi | 30 ++++++++++++++++++++++++++++++
> 2 files changed, 46 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
> index 7cd3640..b062a44 100644
> --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts
> +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts
> @@ -40,10 +40,14 @@
>
> aliases {
> serial0 = &uart3;
> + serial1 = &uart0;
> + serial2 = &uart1;
> + serial3 = &uart2;
> };
>
> chosen {
> stdout-path = "serial0:115200n8";
> + bootargs = "earlycon=uart8250,mmio32,0x66130000";
Hi Jon,
I submit a patch[1], with it, we can use earlycon without option to enable early console
for "snps,dw-apb-uart", could you help me to test it, thanks.
BRs,
Kefeng
[1] https://lkml.org/lkml/2016/5/11/34
> };
>
> memory {
> @@ -68,6 +72,18 @@
> status = "ok";
> };
>
> +&uart0 {
> + status = "ok";
> +};
> +
> +&uart1 {
> + status = "ok";
> +};
> +
> +&uart2 {
> + status = "ok";
> +};
> +
> &uart3 {
> status = "ok";
> };
> diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi b/arch/arm64/boot/dts/broadcom/ns2.dtsi
> index 788ed8f..c77a9e8 100644
> --- a/arch/arm64/boot/dts/broadcom/ns2.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/ns2.dtsi
> @@ -357,6 +357,36 @@
> status = "disabled";
> };
>
> + uart0: serial@66100000 {
> + compatible = "snps,dw-apb-uart";
> + reg = <0x66100000 0x100>;
> + interrupts = <GIC_SPI 390 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&iprocslow>;
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> + uart1: serial@66110000 {
> + compatible = "snps,dw-apb-uart";
> + reg = <0x66110000 0x100>;
> + interrupts = <GIC_SPI 391 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&iprocslow>;
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> + uart2: serial@66120000 {
> + compatible = "snps,dw-apb-uart";
> + reg = <0x66120000 0x100>;
> + interrupts = <GIC_SPI 392 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&iprocslow>;
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> uart3: serial@66130000 {
> compatible = "snps,dw-apb-uart";
> reg = <0x66130000 0x100>;
>
next prev parent reply other threads:[~2016-05-12 6:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 22:56 [PATCH 1/2] arm64: dts: NS2: Add all of the UARTs Jon Mason
2016-05-12 6:16 ` Kefeng Wang [this message]
2016-05-12 14:46 ` Jon Mason
2016-05-12 16:52 ` Ray Jui
2016-05-13 1:17 ` Kefeng Wang
2016-05-13 2:09 ` Kefeng Wang
2016-05-13 16:49 ` Jon Mason
2016-05-16 1:11 ` Kefeng Wang
[not found] ` <57391E45.8010209-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-05-17 19:56 ` Florian Fainelli
[not found] ` <573B775F.4060503-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-18 5:50 ` Kefeng Wang
[not found] ` <1463007369-13071-1-git-send-email-jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-05-11 22:56 ` [PATCH 2/2] arm64: dts: NS2: Add CCI-400 PMU support Jon Mason
[not found] ` <1463007369-13071-2-git-send-email-jonmason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-05-20 18:45 ` Florian Fainelli
2016-05-20 18:45 ` [PATCH 1/2] arm64: dts: NS2: Add all of the UARTs Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57341FCE.6050403@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jon.mason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).