From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olliver Schinagl Subject: Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile Date: Fri, 13 May 2016 10:07:07 +0200 Message-ID: <57358B2B.1010703@schinagl.nl> References: <1463047851-2039-1-git-send-email-oliver@schinagl.nl> <20160513074823.GA3733@lukather> Reply-To: oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20160513074823.GA3733@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Chen-Yu Tsai List-Id: devicetree@vger.kernel.org and now i'm embarrassed and ashamed. Teaches me not to rush things, right? i'll correct it and take some time to do it right. sorry maxime! On 13-05-16 09:48, Maxime Ripard wrote: > Hi Olliver, > > On Thu, May 12, 2016 at 12:10:51PM +0200, Olliver Schinagl wrote: >> commit 27dd9af6bc (ARM: dts: sunxi: Add a olinuxino-lime2-emmc added the new >> emmc equipped) lime2 but forgot its Makefile. > This is still not the right commit format, the commit title should be > around double quotes. checkpatch both reports an error for this and > tells you what the proper format is, so please remember to use it > before you're sending a patch. > > Thanks! > Maxime >