devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Carlo Caione <carlo@caione.org>
Cc: linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, jerry.cao@amlogic.com,
	devicetree@vger.kernel.org, xing.xu@amlogic.com,
	victor.wan@amlogic.com
Subject: Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller
Date: Fri, 20 May 2016 10:51:40 +0200	[thread overview]
Message-ID: <573ED01C.2070800@baylibre.com> (raw)
In-Reply-To: <20160520084646.GB16732@mephisto>

On 05/20/2016 10:46 AM, Carlo Caione wrote:
> On 20/05/16 10:27, Neil Armstrong wrote:
>> Add DT bindings for the Meson GXBB SoC Reset Controller documentation and the
>> associated include file.
> 
> [...]
> 
>> +#define RESET_I2C_MASTER_2	142
>> +#define RESET_I2C_MASTER_1	143
>> +/*				144-159	*/
>> +/*	RESET5				*/
>> +/*				160-191	*/
>> +/*	RESET6				*/
>> +#define RESET_PERIPHS_GENERAL	192
>> +#define RESET_PERIPHS_SPICC	193
>> +#define RESET_PERIPHS_SMART_CARD	194
>> +#define RESET_PERIPHS_SAR_ADC	195
>> +#define RESET_PERIPHS_I2C_MASTER_0	196
>> +#define RESET_SANA		197
>> +/*				198	*/
>> +#define RESET_PERIPHS_STREAM_INTERFACE	199
>> +#define RESET_PERIPHS_SDIO	200
>> +#define RESET_PERIPHS_UART_0	201
>> +#define RESET_PERIPHS_UART_1_2	202
>> +#define RESET_PERIPHS_ASYNC_0	203
>> +#define RESET_PERIPHS_ASYNC_1	204
>> +#define RESET_PERIPHS_SPI_0	205
>> +#define RESET_PERIPHS_SDHC	206
>> +#define RESET_UART_SLIP		207
>> +/*				208-223	*/
>> +/*	RESET7				*/
>> +#define RESET_USB_DDR_0		224
>> +#define RESET_USB_DDR_1		225
>> +#define RESET_USB_DDR_2		226
>> +#define RESET_USB_DDR_3		227
>> +/*				228	*/
>> +#define RESET_DEVICE_MMC_ARB	229
>> +/*				230	*/
>> +#define RESET_VID_LOCK		231
>> +#define RESET_A9_DMC_PIPEL	232
>> +/*				233-255	*/
>> +
>> +#endif
> 
> Indentation looks really messy. Can you just shift the numbers to the
> right so that they are on the same column?
> 
Hi Carlo,

The patch format makes it very messy, not as in the original format :
https://github.com/superna9999/linux/blob/6163f8742454bb7ff962956b4e286d110ec0fb79/include/dt-bindings/reset/amlogic%2Cmeson-gxbb-reset.h

Neil

  reply	other threads:[~2016-05-20  8:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1463732875-23141-1-git-send-email-narmstrong@baylibre.com>
     [not found] ` <1463732875-23141-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-05-20  8:27   ` [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller Neil Armstrong
     [not found]     ` <1463732875-23141-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-05-20  8:46       ` Carlo Caione
2016-05-20  8:51         ` Neil Armstrong [this message]
2016-05-20  9:08           ` Carlo Caione
2016-05-20 12:18             ` Neil Armstrong
2016-05-23 21:04     ` Rob Herring
2016-05-20  8:27 ` [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms Neil Armstrong
     [not found]   ` <1463732875-23141-4-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-05-20  8:47     ` Carlo Caione
2016-05-20  8:53       ` Neil Armstrong
     [not found]         ` <573ED06F.9070909-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-05-20  9:10           ` Carlo Caione
2016-05-20 12:19             ` Neil Armstrong
2016-05-20 12:22               ` Carlo Caione
2016-05-20 12:23                 ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573ED01C.2070800@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=carlo@caione.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jerry.cao@amlogic.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=victor.wan@amlogic.com \
    --cc=xing.xu@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).