From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] ARM: dts: exynos: Remove unneded always-on for regulators on Peach boards Date: Fri, 20 May 2016 11:54:58 +0200 Message-ID: <573EDEF2.8020903@samsung.com> References: <1463694753-7259-1-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1463694753-7259-1-git-send-email-javier@osg.samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: devicetree@vger.kernel.org, Kukjin Kim , Kumar Gala , Ian Campbell , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 05/19/2016 11:52 PM, Javier Martinez Canillas wrote: > The regulator always-on property should only be used for regulators > that either can't be disabled or the drivers for the client devices > are not enabling the regulator and so being disabled due to unused. > > There are some max77802 regulators in the Peach Pit and Pi boards > that are always-on but shouldn't since they are enabled by drivers: > > BUCK5 is max77802 inl1 supply > BUCK7 is max77802 inl{2,10} supply > BUCK9 is max77802 inl{3,4,5,7} supply > BUCK10 is mmc1 vqmmc supply > LDO9 is adc vdd supply > > This patch removes the always-on property for these regulators. > > Some regulators should remain always-on even when they are used as > input supplies, because these regulators are also used by other > components that are not described in the DT, for example: > > LDO10 is hdmi vdd_osc supply but it's also used as input supply for > the Exynos5420 temperature sensor. I don't have the schematics, so just guessing: by temperature sensor do you mean the tmu_cpu* node (supplying power to VDD_TS01/23/4)? If yes then you can also change it, like on Odroid XU boards. > > LDO8 is hdmi vdd and vdd_pll supply but it's also used as supply for > the Exynos5420 Display port. > > BUCK2 and BUCK6 are the vdd supplies for the EAGLE and KFC clusters. > > Signed-off-by: Javier Martinez Canillas > --- > > arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 ----- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 ----- > 2 files changed, 10 deletions(-) Anyway, Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof