From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Aakarsh Jain <aakarsh.jain@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com,
benjamin.gaignard@collabora.com,
krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org,
dillon.minfei@gmail.com, david.plowman@raspberrypi.com,
mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org,
andi@etezian.org, alim.akhtar@samsung.com,
aswani.reddy@samsung.com, pankaj.dubey@samsung.com,
smitha.t@samsung.com
Subject: Re: [Patch v2 1/3] arm: exynos: Add new compatible string for Exynos3250 SoC.
Date: Wed, 9 Nov 2022 10:01:28 +0100 [thread overview]
Message-ID: <5741e444-00b3-16f6-d012-f2b77cf8b0b2@linaro.org> (raw)
In-Reply-To: <20221109035507.69086-1-aakarsh.jain@samsung.com>
On 09/11/2022 04:55, Aakarsh Jain wrote:
> Since,MFC v7 support was added for Exynos5420 and Exynos
> 3250 SoC with same compatible string "samsung,mfc-v7".As
> both SoCs having different hardware properties and having
> same compatible string for both SoCs doesn't seems to be correct.
> New compatible is added for Exynos3250 SOC which will
> differentiate the node properties for both SoCs which
> support MFC v7.
>
> Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> Suggested-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
> ---
> Documentation/devicetree/bindings/media/s5p-mfc.txt | 9 +++++----
Use subject prefixes matching the subsystem (git log --oneline -- ...).
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-09 9:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221109034803epcas5p26644fa402ff1837754b61c1a307b2bb8@epcas5p2.samsung.com>
2022-11-09 3:55 ` [Patch v2 1/3] arm: exynos: Add new compatible string for Exynos3250 SoC Aakarsh Jain
[not found] ` <CGME20221109034807epcas5p2eae5872bb8fb3e970c1bade98dd171c5@epcas5p2.samsung.com>
2022-11-09 3:55 ` [Patch v2 2/3] media: s5p-mfc:Add variant data for MFC v7 hardware for Exynos 3250 SoC Aakarsh Jain
[not found] ` <CGME20221109034811epcas5p4ecd94497380c5342258fc1dac7f99956@epcas5p4.samsung.com>
2022-11-09 3:55 ` [Patch v2 3/3] arm: dts: exynos: Rename compatible string property from version to SoC specific Aakarsh Jain
2022-11-09 9:01 ` Krzysztof Kozlowski
2022-11-09 9:01 ` Krzysztof Kozlowski [this message]
2022-11-09 14:44 ` [Patch v2 1/3] arm: exynos: Add new compatible string for Exynos3250 SoC Aakarsh Jain
2022-11-10 8:25 ` Krzysztof Kozlowski
2022-11-11 3:19 ` Aakarsh Jain
2022-11-09 9:13 ` Krzysztof Kozlowski
2022-11-11 3:20 ` Aakarsh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5741e444-00b3-16f6-d012-f2b77cf8b0b2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aakarsh.jain@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=andi@etezian.org \
--cc=andrzej.hajda@intel.com \
--cc=aswani.reddy@samsung.com \
--cc=benjamin.gaignard@collabora.com \
--cc=david.plowman@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=smitha.t@samsung.com \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).