From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCB1C4332F for ; Wed, 9 Nov 2022 09:01:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230177AbiKIJBg (ORCPT ); Wed, 9 Nov 2022 04:01:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230171AbiKIJBd (ORCPT ); Wed, 9 Nov 2022 04:01:33 -0500 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F7F01E3D5 for ; Wed, 9 Nov 2022 01:01:31 -0800 (PST) Received: by mail-lj1-x232.google.com with SMTP id t10so24831653ljj.0 for ; Wed, 09 Nov 2022 01:01:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=koi87UBrY+4VbIvBhOaMl54U0jWmVKM7mhP4eLxgcCM=; b=pYyHtrWUHIUnG+wcIiuyl8Eb4xpHSKWAbbm2UUGW+KAXP1NEZ5VG6w+KCCeVZDMvA6 xG0Afks2KDaRV8ZceEPEFN2cR6hlLiyqaBnfwVmfNfAm0mqPCqTf16Bui1CL0AzeI/jl UJrBkDY3mWGCs41//YNt9kXSV1nlSqVf/qU/d1xdI3CDV5Ysz6Ns/LQ2zTF+LAm4cAD3 /Kt6hF2qRXx8UuklDBKOVfGgBSUX5aTqm6iE338qmimwzVn3HSyK4MyERUePThBrL95T RSBHm+AvgOeYlCqvCQSudofFWbQfRZ71UE4pZnExgvX9GUlfeqJeBP/uT6sz1rRTtfKh iMJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=koi87UBrY+4VbIvBhOaMl54U0jWmVKM7mhP4eLxgcCM=; b=VyfXb0QUnf6cWY8SDLd9nk7DNpmBVXavIRzY4hYxbPp81Vr4LxglXTbo81/PSZikEH VB+KbpbAtKVpo/J+dsOWzfsr38iTqisKEjAFgQ1notv8x/WXNHKwdbdP+3Lb1Bl866Q9 zNjNWX2Cy45k3JM/NEyxmH+mMYFfdLPL5Gn1l7yJZ3XjCkLaDghX4ObiV3VXhwk0uiFJ jJ8zosEMejY8ssHSIt1kDxjqf1FbwFsEVc8aJN++zelAJFjs6mtq9PbuiHg1eE1IwdFs h+SjM6Qssk1p0zJcXCZLN0BkYUCXZhDKlM12G5VcrB/JL0ChLb/9ziBzyjNJrscG3Nrh 0fTQ== X-Gm-Message-State: ACrzQf3Qdbazzq3Ev8finX8698PQA0hYL0/yVtCazuBJ0thZ7rRJv1GJ 7tgnCAt9rShVg0kSNpMNqnlAUA== X-Google-Smtp-Source: AMsMyM68gD6nF6Ys++aTB+8/odStmcWWdBR+jCLTj5ELwjEBJoftvdDjO2Ka2/JTTfzis+5UjDtBQg== X-Received: by 2002:a2e:9a88:0:b0:26f:c489:883e with SMTP id p8-20020a2e9a88000000b0026fc489883emr7498644lji.281.1667984489818; Wed, 09 Nov 2022 01:01:29 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id b2-20020a05651c032200b0026bf43a4d72sm2062535ljp.115.2022.11.09.01.01.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 01:01:29 -0800 (PST) Message-ID: <5741e444-00b3-16f6-d012-f2b77cf8b0b2@linaro.org> Date: Wed, 9 Nov 2022 10:01:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [Patch v2 1/3] arm: exynos: Add new compatible string for Exynos3250 SoC. Content-Language: en-US To: Aakarsh Jain , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, smitha.t@samsung.com References: <20221109035507.69086-1-aakarsh.jain@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20221109035507.69086-1-aakarsh.jain@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/11/2022 04:55, Aakarsh Jain wrote: > Since,MFC v7 support was added for Exynos5420 and Exynos > 3250 SoC with same compatible string "samsung,mfc-v7".As > both SoCs having different hardware properties and having > same compatible string for both SoCs doesn't seems to be correct. > New compatible is added for Exynos3250 SOC which will > differentiate the node properties for both SoCs which > support MFC v7. > > Reviewed-by: Tommaso Merciai > Suggested-by: Alim Akhtar > Signed-off-by: Aakarsh Jain > --- > Documentation/devicetree/bindings/media/s5p-mfc.txt | 9 +++++---- Use subject prefixes matching the subsystem (git log --oneline -- ...). This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof