Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01

Heiko Stübner
2024-07-26T21:57:52Z

Am Freitag, 19. Juli 2024, 16:45:24 CEST schrieb Conor Dooley:
> On Fri, Jul 19, 2024 at 08:12:08AM -0300, Fabio Estevam wrote:
> > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace.
> > The marking on the LCD is JG10309-01.
> >
> > Add an entry for the "elgin,jg10309-01" compatible string.
> >
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Please send cover letter for patch series. The whole lot seems fine,
> although ideally this wouldn't be in trivial devices - but I think the
> series is an improvement on lying about what's on the board ;)
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

with the error Rob's bot reported about the usage of spi-cpol and
spi-cpha, it really looks like the bindings needs to be more fleshed out.