Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01

Conor Dooley
2024-08-05T22:05:55Z

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

On Mon, Aug 05, 2024 at 10:18:24AM -0300, Fabio Estevam wrote:
> Hi Heiko,
>
> On Fri, Jul 26, 2024 at 6:57 PM Heiko Stübner <heiko@sntech.de> wrote:
>
> > with the error Rob's bot reported about the usage of spi-cpol and
> > spi-cpha, it really looks like the bindings needs to be more fleshed out.
>
> I just wanted to let you know that the warning reported by Rob's bot
> is very old.
>
> Running "make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml" on the
> existing tree:
>
> DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb
> rv1108-elgin-r1.dtb: dac@0: 'spi-cpha', 'spi-cpol' do not match any of
> the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
>
> So we are not making things worse in this aspect.
>
> I can work on removing the warnings as an incremental patch, if you agree.

Yeah, I acked it cos the issue would've been there before so it's not
any worse. I think adding a "real" binding can be a follow on.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]