devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
	Christer Weinigel <christer@weinigel.se>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] devicetree - document using aliases to set spi bus number.
Date: Wed, 25 May 2016 11:06:46 -0700	[thread overview]
Message-ID: <5745E9B6.5090204@gmail.com> (raw)
In-Reply-To: <20160525174932.GA10753@rob-hp-laptop>

On 5/25/2016 10:49 AM, Rob Herring wrote:
> On Tue, May 24, 2016 at 04:34:50PM -0700, Frank Rowand wrote:
>> On 5/24/2016 11:32 AM, Mark Brown wrote:
>>> On Tue, May 24, 2016 at 08:03:48PM +0200, Christer Weinigel wrote:
>>>> On 05/24/2016 07:20 PM, Mark Brown wrote:
>>>
>>>>> I'm not sure this is something we want to support at all, I can't 
>>>>> immediately see anything that does this deliberately in the SPI
>>>>> code and obviously the "bus number" is something of a Linux
>>>>> specific concept which would need some explanation if we were going
>>>>> to document it.  It's something I'm struggling a bit to see a
>>>>> robust use case for that isn't better served by parsing sysfs,
>>>>> what's the goal here?
>>>
>>>> If this isn't something that should be in the Documentation/devicetree
>>>>  because it's not generig enough, where should Linux-specific
>>>> interpretations such as this be documented?
>>>
>>> I'm not clear that we want to document this at all since I am not clear
>>> that there is a sensible use case for doing it.  I did ask for one but
>>> you've not articulated one in this reply.  I am much less gung ho than
>>> Grant on this one, even as a Linux specific interface it seems very
>>> legacy.
> 
> No, we don't.
> 
>>>
>>
>> The time for the use case was when the patch was accepted.
> 
> Ideally, yes, but things getting missed in review or later deciding 
> things were a bad idea can always be debated again.
> 
>> It is in the kernel, it is appropriate to document it.
> 
> Things get undocumented all the time when we deprecate them.

If it is deprecated then it should be documented as deprecated so
people do not attempt to use it.

> 
> Rob
> 

  parent reply	other threads:[~2016-05-25 18:06 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 16:39 [PATCH] devicetree - document using aliases to set spi bus number Christer Weinigel
2016-05-24 17:20 ` Mark Brown
2016-05-24 18:03   ` Christer Weinigel
2016-05-24 18:32     ` Mark Brown
     [not found]       ` <20160524183256.GP8206-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-24 18:57         ` Christer Weinigel
     [not found]           ` <5744A402.8050409-rKHMIqA5R6gwFerOooGFRg@public.gmane.org>
2016-05-25 12:19             ` Mark Rutland
2016-05-25 12:50               ` Mark Brown
2016-05-25 12:33             ` Mark Brown
2016-05-24 23:34         ` Frank Rowand
     [not found]           ` <5744E51A.1040506-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-25  0:18             ` Frank Rowand
2016-05-25 17:49           ` Rob Herring
2016-05-25 18:03             ` Mark Brown
2016-05-25 18:06             ` Frank Rowand [this message]
2016-05-25 18:44               ` Mark Brown
2016-05-26  1:10                 ` Christer Weinigel
     [not found]                   ` <57464D0A.1030706-rKHMIqA5R6gwFerOooGFRg@public.gmane.org>
2016-05-26  1:44                     ` Rob Herring
2016-05-26  1:56                       ` Christer Weinigel
     [not found]                         ` <574657BB.6070300-rKHMIqA5R6gwFerOooGFRg@public.gmane.org>
2016-05-26 10:07                           ` Mark Brown
2016-05-26 10:58                             ` Christer Weinigel
     [not found]                               ` <5746D6CE.5020605-rKHMIqA5R6gwFerOooGFRg@public.gmane.org>
2016-05-26 18:47                                 ` Mark Brown
     [not found]                                   ` <20160526184746.GF16172-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-05-26 21:04                                     ` Christer Weinigel
2016-05-27 16:43                                       ` Mark Brown
2016-05-24 17:41 ` Mark Rutland
2016-05-24 20:41   ` Frank Rowand
     [not found]     ` <5744BC76.9090403-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-25  9:20       ` Mark Rutland
2016-05-25 10:38         ` Mark Brown
2016-05-25 11:20           ` Christer Weinigel
     [not found]             ` <57458A64.2090901-rKHMIqA5R6gwFerOooGFRg@public.gmane.org>
2016-05-25 12:34               ` Mark Rutland
2016-05-25 13:08                 ` Mark Brown
2016-05-25 15:32         ` Frank Rowand
     [not found]           ` <5745C5A3.6060202-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-25 15:59             ` Mark Rutland
2016-05-25 16:21               ` Frank Rowand
2016-05-25 18:02               ` Mark Brown
2016-05-25 17:48             ` Mark Brown
2016-05-25 18:46               ` Frank Rowand
     [not found]                 ` <5745F30B.2040605-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-27 18:36                   ` Mark Brown
2016-05-28 20:57                     ` Christer Weinigel
     [not found]                       ` <574A063D.5030700-rKHMIqA5R6gwFerOooGFRg@public.gmane.org>
2016-05-30 16:13                         ` Mark Brown
2016-05-25 15:25   ` Frank Rowand
     [not found]     ` <5745C3F8.4020909-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-25 16:06       ` Mark Rutland
2016-05-25 16:31         ` Frank Rowand
2016-05-25 18:44   ` Rob Herring
2016-05-25 18:48     ` Mark Brown
2016-05-26  8:21     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5745E9B6.5090204@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=broonie@kernel.org \
    --cc=christer@weinigel.se \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).