From: mr.nuke.me@gmail.com
To: Krzysztof Kozlowski <krzk@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: ipq9574: Use 'usb-phy' for node names
Date: Wed, 10 Dec 2025 10:44:36 -0600 [thread overview]
Message-ID: <5749e29a-79e7-4a0e-b23c-aee0df23820a@gmail.com> (raw)
In-Reply-To: <ca3934c2-532f-4744-bf7c-2480048c7fef@kernel.org>
On 12/10/25 12:03 AM, Krzysztof Kozlowski wrote:
> On 09/12/2025 22:59, mr.nuke.me@gmail.com wrote:
>>
>>
>> On 12/9/25 3:48 PM, Krzysztof Kozlowski wrote:
>>> On 09/12/2025 17:26, mr.nuke.me@gmail.com wrote:
>>>> On 12/9/25 10:17 AM, Dmitry Baryshkov wrote:
>>>>> On Tue, Dec 09, 2025 at 10:07:54AM -0600, Alexandru Gagniuc wrote:
>>>>>> The devicetree spec allows node names of "usb-phy". So be more
>>>>>> specific for the USB PHYs, and name the nodes "usb-phy" instead of
>>>>>> just "phy".
>>>>>
>>>>> Why? "phy" is more generic.
>>>>
>>>> Hi Dmitry,
>>>>
>>>> The goal is to be more specific. I find usb-phy, ethernet-phy and others
>>>
>>> We do not have such goal. Where did you find that goal documented?
>>
>> If the goal isn't to be specific, clear, and readable, what is it? Why not be generic, and call subnodes node@, or dev@ ?
>
>
> Did you read the spec you referred to? What sort of class of devices
> represents "node"?
My statement was intended to be a reduction ad absurdum to the generic
naming argument, rather than my public exam on the dt 0.4 spec.
I find it useful to have node names that identify the function as
clearly as possible, or to see ethernet-phy and usb-phy under
/proc/device-tree/soc@0/ and /sys/bus/platform/devices/. That was
_my_ goal. Obviously, you and Dmitry disagree with that goal.
Alex
next prev parent reply other threads:[~2025-12-10 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 16:07 [PATCH] arm64: dts: qcom: ipq9574: Use 'usb-phy' for node names Alexandru Gagniuc
2025-12-09 16:17 ` Dmitry Baryshkov
2025-12-09 16:26 ` mr.nuke.me
2025-12-09 21:48 ` Krzysztof Kozlowski
2025-12-09 21:59 ` mr.nuke.me
2025-12-10 6:03 ` Krzysztof Kozlowski
2025-12-10 16:44 ` mr.nuke.me [this message]
2025-12-09 21:47 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5749e29a-79e7-4a0e-b23c-aee0df23820a@gmail.com \
--to=mr.nuke.me@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).