From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Nortmann Subject: Re: [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board Date: Thu, 2 Jun 2016 11:15:55 +0200 Message-ID: <574FF94B.3020309@web.de> References: <20160602023623.5761-1-luoyi.ly@gmail.com> <20160602081638.GG4908@lukather> Reply-To: bernhard.nortmann-S0/GAf8tV78@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20160602081638.GG4908@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, Julian Calaby Cc: luoyi.ly-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Chen-Yu Tsai , devicetree , "Mailing List, Arm" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-sunxi List-Id: devicetree@vger.kernel.org Am 02.06.2016 um 10:16 schrieb Maxime Ripard: > [...] > Yes, everything that is shared with the banana-pro (which, judging > from Bernhard, is pretty much everything but a GPIO) should be merged > in the banapro DT. > > Maxime > Don't take my word for granted, as I do not own this hardware or know it particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are very similar, but if in doubt the information form the wiki should be verified. @luoyi: You seem to be using an editor that uses 4 spaces for displaying a . It looks like that makes you prone to whitespace formatting issues, which have shown up in both versions of the .dts you submitted so far. Please double-check that you're using TABs for indentation and they weren't mixed up with SPACEs accidentally. (Most editors will also offer a setting that allows you to display "non-printable" chars, where you might be able to distinguish whitespace better.) Regards, B. Nortmann