From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keerthy Subject: Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Date: Thu, 20 Jul 2017 15:40:22 +0530 Message-ID: <574e0ecc-df20-e2da-46a5-a90a80cc57e3@ti.com> References: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> <1500375436-9435-3-git-send-email-j-keerthy@ti.com> <20170719111000.GX29638@localhost> <20170720095047.GA2729@localhost> <47055927-5102-b39f-fdbb-b5d89cb14632@ti.com> <20170720100509.GB2729@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170720100509.GB2729@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Johan Hovold Cc: devicetree@vger.kernel.org, linus.walleij@linaro.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, robh+dt@kernel.org, fcooper@ti.com, ssantosh@kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Thursday 20 July 2017 03:35 PM, Johan Hovold wrote: > On Thu, Jul 20, 2017 at 03:32:27PM +0530, Keerthy wrote: >> On Thursday 20 July 2017 03:20 PM, Johan Hovold wrote: >>> On Thu, Jul 20, 2017 at 02:40:37PM +0530, Keerthy wrote: >>>> On Thursday 20 July 2017 12:14 PM, Keerthy wrote: >>>>> On Wednesday 19 July 2017 04:40 PM, Johan Hovold wrote: > >>>>>> There's a separate but related bug here too as the clk_prepare_enable() >>>>>> in davinci_gpio_irq_setup() is never balanced on driver unbind. >>>>> >>>>> Yes Johan. I will send that as a separate patch. >>>> >>>> This is already fixed in the latest kernel: >>>> >>>> commit 6dc0048cff988858254fcc26becfc1e9753efa79 >>>> Author: Arvind Yadav >>>> Date: Tue May 23 14:48:57 2017 +0530 >>> >>> That change only handles errors in davinci_gpio_irq_setup() (i.e. during >>> probe) and not the imbalance at driver unbind that I was referring to. >> >> Okay got it. One more clk_unprepare_disable() call needs to be there in >> probe err path. > > No, you need to balance it on driver unbind, that is, in a new remove() > callback. Okay yes davinci_gpio_irq_setup is the last call in probe so no need of that in probe error path. I will add a new remove() to balance. Thanks, Keerthy > > Johan >