devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keerthy <a0393675@ti.com>
To: Keerthy <j-keerthy@ti.com>,
	broonie@kernel.org, tony@atomide.com, robh+dt@kernel.org,
	mark.rutland@arm.com, lee.jones@linaro.org
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	nikita@compulab.co.il, nm@ti.com
Subject: Re: [PATCH 3/8] mfd: tps65218: Use mfd_add_devices instead of of_platform_populate
Date: Fri, 3 Jun 2016 16:38:57 +0530	[thread overview]
Message-ID: <57516549.6040102@ti.com> (raw)
In-Reply-To: <1462945691-904-4-git-send-email-j-keerthy@ti.com>

Hi Lee Jones,

On Wednesday 11 May 2016 11:18 AM, Keerthy wrote:
> mfd_add_devices enables parsing device tree nodes without compatibles
> for child nodes. Replace of_platform_populate with mfd_add_devices.
>

A gentle ping on this patch.

Regards,
Keerthy

> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>   drivers/mfd/tps65218.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
> index f20a531..b8b3a58 100644
> --- a/drivers/mfd/tps65218.c
> +++ b/drivers/mfd/tps65218.c
> @@ -33,6 +33,10 @@
>
>   #define TPS65218_PASSWORD_REGS_UNLOCK   0x7D
>
> +static const struct mfd_cell tps65218_cells[] = {
> +	{ .name = "tps65218-regulator", },
> +};
> +
>   /**
>    * tps65218_reg_write: Write a single tps65218 register.
>    *
> @@ -236,8 +240,10 @@ static int tps65218_probe(struct i2c_client *client,
>   	if (ret < 0)
>   		return ret;
>
> -	ret = of_platform_populate(client->dev.of_node, NULL, NULL,
> -				   &client->dev);
> +	ret = mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO, tps65218_cells,
> +			      ARRAY_SIZE(tps65218_cells), NULL, 0,
> +			      regmap_irq_get_domain(tps->irq_data));
> +
>   	if (ret < 0)
>   		goto err_irq;
>
>

  reply	other threads:[~2016-06-03 11:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11  5:48 [PATCH 0/8] regulator: tps65218: Clean ups Keerthy
2016-05-11  5:48 ` [PATCH 1/8] mfd: tps65218: Remove redundant read wrapper Keerthy
2016-05-11  5:48 ` [PATCH 2/8] Documentation: regulator: tps65218: Update examples Keerthy
     [not found]   ` <1462945691-904-3-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2016-05-16 14:48     ` Rob Herring
2016-05-17  3:22       ` Keerthy
2016-05-11  5:48 ` [PATCH 3/8] mfd: tps65218: Use mfd_add_devices instead of of_platform_populate Keerthy
2016-06-03 11:08   ` Keerthy [this message]
2016-06-06  9:00     ` Lee Jones
2016-06-08 15:50   ` Lee Jones
2016-06-08 16:09     ` Keerthy
2016-05-11  5:48 ` [PATCH 4/8] regulator: tps65218: Remove all the compatibles Keerthy
2016-05-11 10:21   ` Mark Brown
2016-05-11  5:48 ` [PATCH 5/8] ARM: dts: AM437X-GP-EVM: Remove redundant regulator compatibles Keerthy
     [not found]   ` <1462945691-904-6-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2016-05-12 17:08     ` Tony Lindgren
2016-05-11  5:48 ` [PATCH 6/8] ARM: dts: AM437X-SK-EVM: " Keerthy
2016-05-11  5:48 ` [PATCH 7/8] ARM: dts: AM437X-CM-T43: " Keerthy
2016-05-11  5:48 ` [PATCH 8/8] ARM: dts: AM43X-EPOS-EVM: " Keerthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57516549.6040102@ti.com \
    --to=a0393675@ti.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nikita@compulab.co.il \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).