From: Daniel Schwierzeck <daniel.schwierzeck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Langer,
Thomas" <thomas.langer-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>,
"f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org"
<alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>,
"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"andrew-g2DYL2Zd6BY@public.gmane.org"
<andrew-g2DYL2Zd6BY@public.gmane.org>,
"john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org"
<john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org>,
"openwrt-zg6vgJgm1sizQB+pC5nmwQ@public.gmane.org"
<openwrt-zg6vgJgm1sizQB+pC5nmwQ@public.gmane.org>,
"Mehrtens,
Hauke" <hauke.mehrtens-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"eckert.florian-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org"
<eckert.florian-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC v3 1/3] NET: PHY: adds driver for Intel XWAY PHY
Date: Sat, 4 Jun 2016 17:27:38 +0200 [thread overview]
Message-ID: <5752F36A.4050007@gmail.com> (raw)
In-Reply-To: <0DAF21CFE1B20740AE23D6AF6E54843F1E503ECE-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Am 04.06.2016 um 16:43 schrieb Langer, Thomas:
> Hello Hauke,
>
> [...]
>> +
>> +static int xway_gphy_ack_interrupt(struct phy_device *phydev)
>> +{
>> + int reg;
>> +
>> + /**
>> + * Possible IRQ numbers:
>> + * - IM3_IRL18 for GPHY0
>> + * - IM3_IRL17 for GPHY1
>
> These are references to the SoC interrupts.
>
>> + *
>> + * Due to a silicon bug IRQ lines are not really independent from
>> + * each other. Sometimes the two lines are driven at the same time
>> + * if only one GPHY core raises the interrupt.
>
> So this errata sounds like a SoC errata, not an errata for the PHY.
>
this comment is a remnant from the first driver version which was mainly
used on a VRX200 SoC. But interrupts are generally working fine so this
comment should be removed.
--
- Daniel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-04 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 11:45 [RFC v3 0/3] NET: PHY: Intel XWAY driver Hauke Mehrtens
[not found] ` <1465040728-4904-1-git-send-email-hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org>
2016-06-04 11:45 ` [RFC v3 1/3] NET: PHY: adds driver for Intel XWAY PHY Hauke Mehrtens
2016-06-04 14:43 ` Langer, Thomas
2016-06-04 14:55 ` John Crispin
[not found] ` <0DAF21CFE1B20740AE23D6AF6E54843F1E503ECE-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-06-04 15:27 ` Daniel Schwierzeck [this message]
2016-06-04 11:45 ` [RFC v3 2/3] NET: PHY: Add PHY LED control binding Hauke Mehrtens
2016-06-04 11:45 ` [RFC v3 3/3] NET: PHY: Intel XWAY: add LED configuration support Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5752F36A.4050007@gmail.com \
--to=daniel.schwierzeck-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org \
--cc=andrew-g2DYL2Zd6BY@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=eckert.florian-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org \
--cc=hauke.mehrtens-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=openwrt-zg6vgJgm1sizQB+pC5nmwQ@public.gmane.org \
--cc=thomas.langer-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).