From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
David Daney <david.daney@cavium.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Xinwei Hu <huxinwei@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Robert Richter <rrichter@cavium.com>,
Zefan Li <lizefan@huawei.com>,
Tianhong Ding <dingtianhong@huawei.com>,
Grant Likely <grant.likely@linaro.org>,
Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block
Date: Mon, 6 Jun 2016 09:24:56 +0800 [thread overview]
Message-ID: <5754D0E8.8070009@huawei.com> (raw)
In-Reply-To: <20160603094520.GF9915@arm.com>
On 2016/6/3 17:45, Will Deacon wrote:
> On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote:
>> On 2016/6/2 4:13, Rob Herring wrote:
>>> I believe you still need this and not the one above. You only need it
>>> within the loop if you return. Otherwise, the last node always need to
>>> be put.
>>
>> OK. Thanks.
>>
>> Addition with Matthias's suggestion, I will move "return" into this patch,
>> so that this of_node_put(np) can be safely removed.
>
> Do you want to include Kefeng's [1] patches in your series too? We don't
> need two sets of related NUMA cleanups :)
Yes, It's originally suggested by Joe Perches.
>
> Will
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-June/432715.html
>
> .
>
next prev parent reply other threads:[~2016-06-06 1:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 9:22 [PATCH v2 0/5] fix some type infos and bugs for arm64/of numa Zhen Lei
2016-05-28 9:22 ` [PATCH v2 1/5] of/numa: remove a duplicated pr_debug information Zhen Lei
2016-05-28 9:22 ` [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block Zhen Lei
2016-06-01 20:13 ` Rob Herring
2016-06-02 1:36 ` Leizhen (ThunderTown)
[not found] ` <574F8DA8.4040503-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-03 9:45 ` Will Deacon
[not found] ` <20160603094520.GF9915-5wv7dgnIgG8@public.gmane.org>
2016-06-03 9:50 ` Will Deacon
2016-06-06 1:24 ` Leizhen (ThunderTown) [this message]
2016-06-06 8:03 ` Hanjun Guo
2016-05-28 9:22 ` [PATCH v2 3/5] arm64/numa: add nid check for " Zhen Lei
[not found] ` <1464427377-12712-1-git-send-email-thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-05-28 9:22 ` [PATCH v2 4/5] of/numa: remove a duplicated warning Zhen Lei
2016-05-28 9:22 ` [PATCH v2 5/5] arm64/numa: avoid inconsistent information to be printed Zhen Lei
[not found] ` <1464427377-12712-6-git-send-email-thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-05-31 9:07 ` Matthias Brugger
2016-05-31 11:27 ` Leizhen (ThunderTown)
2016-06-01 1:05 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5754D0E8.8070009@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=dingtianhong@huawei.com \
--cc=frowand.list@gmail.com \
--cc=gkulkarni@caviumnetworks.com \
--cc=grant.likely@linaro.org \
--cc=guohanjun@huawei.com \
--cc=huxinwei@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=robh+dt@kernel.org \
--cc=rrichter@cavium.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).