From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corentin LABBE Subject: Re: [PATCH 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Date: Mon, 6 Jun 2016 20:10:54 +0200 Message-ID: <5755BCAE.6060307@gmail.com> References: <1464947790-22991-1-git-send-email-clabbe.montjoie@gmail.com> <1464947790-22991-4-git-send-email-clabbe.montjoie@gmail.com> <20160606141438.GA9510@rob-hp-laptop> Reply-To: clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20160606141438.GA9510@rob-hp-laptop> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Rob Herring Cc: pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Le 06/06/2016 16:14, Rob Herring a =C3=A9crit : > On Fri, Jun 03, 2016 at 11:56:28AM +0200, LABBE Corentin wrote: >> This patch adds documentation for Device-Tree bindings for the >> Allwinner sun8i-emac driver. >> >> Signed-off-by: LABBE Corentin >> --- >> .../bindings/net/allwinner,sun8i-emac.txt | 64 +++++++++++++++= +++++++ >> 1 file changed, 64 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/allwinner,sun8= i-emac.txt >> >> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.= txt b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt >> new file mode 100644 >> index 0000000..cf71a71 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt >> @@ -0,0 +1,64 @@ >> +* Allwinner sun8i EMAC ethernet controller >> + >> +Required properties: >> +- compatible: "allwinner,sun8i-a83t-emac", "allwinner,sun8i-h3-emac", >> + or "allwinner,sun50i-a64-emac" >> +- reg: address and length of the register sets for the device. >> +- reg-names: should be "emac" and "syscon", matching the register sets >=20 > Is syscon shared with other devices? Your example only has 1 reg=20 > address. >=20 The example is bad, emac and syscon are two distinct regspaces. I will correct the example. >> +- interrupts: interrupt for the device >> +- clocks: A phandle to the reference clock for this device >> +- clock-names: should be "ahb" >> +- resets: A phandle to the reset control for this device >> +- reset-names: should be "ahb" >> +- phy-mode: See ethernet.txt >> +- phy or phy-handle: See ethernet.txt >> +- #address-cells: shall be 1 >> +- #size-cells: shall be 0 >> + >> +"allwinner,sun8i-h3-emac" also requires: >> +- clocks: an extra phandle to the reference clock for the EPHY >> +- clock-names: an extra "ephy" entry matching the clocks property >> +- resets: an extra phandle to the reset control for the EPHY >> +- resets-names: an extra "ephy" entry matching the resets property >> + >> +See ethernet.txt in the same directory for generic bindings for etherne= t >> +controllers. >> + >> +The device node referenced by "phy" or "phy-handle" should be a child n= ode >> +of this node. See phy.txt for the generic PHY bindings. >> + >> +Optional properties: >> +- phy-supply: phandle to a regulator if the PHY needs one >> +- phy-io-supply: phandle to a regulator if the PHY needs a another one = for I/O. >> + This is sometimes found with RGMII PHYs, which use a second >> + regulator for the lower I/O voltage. >=20 > These should go in the phy's node. >=20 In fact, I forgot to remove them, since for the moment, the driver sent do = not have any regulator support. Thanks --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.