Re: [PATCH V3 2/2] thermal: max77620: Add thermal driver for reporting junction temp

[Laxman Dewangan <ldewangan@nvidia.com>]

On Tuesday 07 June 2016 09:18 AM, Keerthy wrote:
> Hi Laxman,
>
> On Monday 06 June 2016 05:14 PM, Laxman Dewangan wrote:
>> Maxim Semiconductor Max77620 supports alarm interrupts when
>> its die temperature crosses 120C and 140C. These threshold
>> temperatures are not configurable.
>>
>> Add thermal driver to register PMIC die temperature as thermal
>> zone sensor and capture the die temperature warning interrupts
>> to notifying the client.
>
> Couple of minor comments.
>
>> +      Support for die junction temperature warning alarm for Maxim
>> +      Semiconductor PMIC MAX77620 device. Device generates two alarm
>> +      interrupts when PMIC die temperature cross the threshold of
>> +      120 degC and 140 degC.
>
> So what are the actions taken for 120C and 140C trips?
> What cooling device is used?
>

The PMIC die temp increases because of higher load on the rails. The 
higher load (more current from rail) is due to if CPU are running on 
higher frequency,

The information is used by the thermal monitoring and throttling system 
and when it sees higher temp on the PMIC die:
- It can reduce the frequency of the CPU or something like this as part 
of thermal throttling.
- If device supports fan then it can increase speed of fans or turn on fan.


>>
>> +};
>> +
>
> This does not give the absolute temperature. So some comments would be 
> really helpful for this function.
>

OK, will add on next rev of patch.