devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Petr Vorel <pevik@seznam.cz>, linux-arm-msm@vger.kernel.org
Cc: Petr Vorel <petr.vorel@gmail.com>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Dominik Kobinski <dominikkobinski314@gmail.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: msm8992-bullhead: Fix cont_splash_mem size
Date: Tue, 27 Dec 2022 12:25:25 +0100	[thread overview]
Message-ID: <575679f4-f7c5-78f8-4f00-4e7bd0ba6be4@linaro.org> (raw)
In-Reply-To: <20221226185440.440968-2-pevik@seznam.cz>



On 26.12.2022 19:54, Petr Vorel wrote:
> From: Petr Vorel <petr.vorel@gmail.com>
> 
> Original google firmware reports 12 MiB:
> [    0.000000] cma: Found cont_splash_mem@0, memory base 0x0000000003400000, size 12 MiB, limit 0xffffffffffffffff
> 
> which is actually 12*1024*1024 = 0xc00000.
> 
> This matches the aosp source [1]:
> &cont_splash_mem {
> 	reg = <0 0x03400000 0 0xc00000>;
> };
> 
> Fixes: 3cb6a271f4b0 ("arm64: dts: qcom: msm8992-bullhead: Fix cont_splash_mem mapping")
> Fixes: 976d321f32dc ("arm64: dts: qcom: msm8992: Make the DT an overlay on top of 8994")
> 
> [1] https://android.googlesource.com/kernel/msm.git/+/android-7.0.0_r0.17/arch/arm64/boot/dts/lge/msm8992-bullhead.dtsi#141
> 
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> Hi,
> 
> I'm sorry for introducing a regression.
> 
> Kind regards,
> Petr
> 
>  arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> index 79de9cc395c4..123ec67fb385 100644
> --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> @@ -2,7 +2,7 @@
>  /*
>   * Copyright (c) 2015, LGE Inc. All rights reserved.
>   * Copyright (c) 2016, The Linux Foundation. All rights reserved.
> - * Copyright (c) 2021, Petr Vorel <petr.vorel@gmail.com>
> + * Copyright (c) 2021-2022, Petr Vorel <petr.vorel@gmail.com>
>   * Copyright (c) 2022, Dominik Kobinski <dominikkobinski314@gmail.com>
>   */
>  
> @@ -49,7 +49,7 @@ ramoops@1ff00000 {
>  		};
>  
>  		cont_splash_mem: memory@3400000 {
> -			reg = <0 0x03400000 0 0x1200000>;
> +			reg = <0 0x03400000 0 0xc00000>;
>  			no-map;
>  		};
>  

  reply	other threads:[~2022-12-27 11:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-26 18:54 [PATCH 0/3] msm8992-bullhead: 2 DTS fixes + 1 RFC Petr Vorel
2022-12-26 18:54 ` [PATCH 1/3] arm64: dts: qcom: msm8992-bullhead: Fix cont_splash_mem size Petr Vorel
2022-12-27 11:25   ` Konrad Dybcio [this message]
2022-12-26 18:54 ` [PATCH 2/3] arm64: dts: qcom: msm8992-bullhead: Disable dfps_data_mem Petr Vorel
2022-12-27 11:25   ` Konrad Dybcio
2022-12-26 18:54 ` [PATCH 3/3] [RFC] arm64: dts: qcom: msm8992-bullhead: Fix smem_region, mpss_mem Petr Vorel
2022-12-27 11:29   ` Konrad Dybcio
2023-01-18 23:55 ` (subset) [PATCH 0/3] msm8992-bullhead: 2 DTS fixes + 1 RFC Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575679f4-f7c5-78f8-4f00-4e7bd0ba6be4@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dominikkobinski314@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=petr.vorel@gmail.com \
    --cc=pevik@seznam.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).