From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent ABRIOU Subject: Re: [PATCH v2 2/3] drm: convert DT component matching to component_match_add_release() Date: Tue, 7 Jun 2016 16:26:13 +0200 Message-ID: <5756D985.80107@st.com> References: <20160603141548.GC1041@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Russell King , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" Cc: Heiko Stuebner , David Airlie , Liviu Dudau , Rob Clark , Christian Gmeiner , Benjamin Gaignard , Lucas Stach , "freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Mark Yao List-Id: devicetree@vger.kernel.org On 06/03/2016 04:21 PM, Russell King wrote: > Convert DT component matching to use component_match_add_release(). > > Signed-off-by: Russell King > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 9 +++------ > drivers/gpu/drm/armada/armada_drv.c | 8 ++------ > drivers/gpu/drm/drm_of.c | 6 ++++-- > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 11 ++--------- > drivers/gpu/drm/msm/msm_drv.c | 8 ++------ > drivers/gpu/drm/msm/msm_drv.h | 1 + > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 12 +++--------- > drivers/gpu/drm/sti/sti_drv.c | 9 ++------- > drivers/gpu/drm/tilcdc/tilcdc_external.c | 8 ++------ > 9 files changed, 21 insertions(+), 51 deletions(-) > > > diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c > index 872495e72294..aeb2787c9bd4 100644 > --- a/drivers/gpu/drm/sti/sti_drv.c > +++ b/drivers/gpu/drm/sti/sti_drv.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > > #include > @@ -341,11 +342,6 @@ static struct drm_driver sti_driver = { > .minor = DRIVER_MINOR, > }; > > -static int compare_of(struct device *dev, void *data) > -{ > - return dev->of_node == data; > -} > - > static int sti_bind(struct device *dev) > { > return drm_platform_init(&sti_driver, to_platform_device(dev)); > @@ -375,8 +371,7 @@ static int sti_platform_probe(struct platform_device *pdev) > child_np = of_get_next_available_child(node, NULL); > > while (child_np) { > - component_match_add(dev, &match, compare_of, child_np); > - of_node_put(child_np); > + component_match_add_of(dev, &match, child_np); > child_np = of_get_next_available_child(node, child_np); > } > Hi Russel, Ok for the sti driver. Acked-by: Vincent Abriou