* Re: [PATCH] of: reserved_mem: restore old behavior when no region is defined
2016-06-08 6:51 ` [PATCH] of: reserved_mem: restore old behavior when no region is defined Marek Szyprowski
@ 2016-06-08 7:35 ` Sylwester Nawrocki
2016-06-08 10:49 ` Liviu Dudau
2016-06-08 13:05 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Sylwester Nawrocki @ 2016-06-08 7:35 UTC (permalink / raw)
To: linux-media, Mauro Carvalho Chehab
Cc: Marek Szyprowski, linux-samsung-soc, dri-devel, linux-arm-kernel,
devicetree, Kamil Debski, Krzysztof Kozlowski,
Javier Martinez Canillas, Bartlomiej Zolnierkiewicz, Robin Murphy,
Liviu Dudau, Daniel Vetter
On 06/08/2016 08:51 AM, Marek Szyprowski wrote:
> Change return value back to -ENODEV when no region is defined for given
> device. This restores old behavior of this function, as some drivers rely
> on such error code.
>
> Reported-by: Liviu Dudau <liviu.dudau@arm.com>
> Fixes: 59ce4039727ef40 ("of: reserved_mem: add support for using more than
> one region for given device")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
I think this needs to be added to the media tree, where the original
patch it fixes was applied.
--
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] of: reserved_mem: restore old behavior when no region is defined
2016-06-08 6:51 ` [PATCH] of: reserved_mem: restore old behavior when no region is defined Marek Szyprowski
2016-06-08 7:35 ` Sylwester Nawrocki
@ 2016-06-08 10:49 ` Liviu Dudau
2016-06-08 13:05 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Liviu Dudau @ 2016-06-08 10:49 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-media, linux-samsung-soc, dri-devel, linux-arm-kernel,
devicetree, Kamil Debski, Bartlomiej Zolnierkiewicz,
Daniel Vetter, Mauro Carvalho Chehab, Krzysztof Kozlowski,
Javier Martinez Canillas, Sylwester Nawrocki, Robin Murphy
On Wed, Jun 08, 2016 at 08:51:53AM +0200, Marek Szyprowski wrote:
> Change return value back to -ENODEV when no region is defined for given
> device. This restores old behavior of this function, as some drivers rely
> on such error code.
>
> Reported-by: Liviu Dudau <liviu.dudau@arm.com>
> Fixes: 59ce4039727ef40 ("of: reserved_mem: add support for using more than
> one region for given device")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com>
> ---
> drivers/of/of_reserved_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 3cf129f..06af99f 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -334,7 +334,7 @@ int of_reserved_mem_device_init_by_idx(struct device *dev,
>
> target = of_parse_phandle(np, "memory-region", idx);
> if (!target)
> - return -EINVAL;
> + return -ENODEV;
>
> rmem = __find_rmem(target);
> of_node_put(target);
> --
> 1.9.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] of: reserved_mem: restore old behavior when no region is defined
2016-06-08 6:51 ` [PATCH] of: reserved_mem: restore old behavior when no region is defined Marek Szyprowski
2016-06-08 7:35 ` Sylwester Nawrocki
2016-06-08 10:49 ` Liviu Dudau
@ 2016-06-08 13:05 ` Rob Herring
2016-06-08 15:35 ` Sumit Semwal
2 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2016-06-08 13:05 UTC (permalink / raw)
To: Marek Szyprowski
Cc: devicetree@vger.kernel.org, Kamil Debski,
linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz,
Daniel Vetter, Mauro Carvalho Chehab, Liviu Dudau,
Krzysztof Kozlowski, dri-devel, Javier Martinez Canillas,
Sylwester Nawrocki, Robin Murphy,
linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org
On Wed, Jun 8, 2016 at 1:51 AM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> Change return value back to -ENODEV when no region is defined for given
> device. This restores old behavior of this function, as some drivers rely
> on such error code.
>
> Reported-by: Liviu Dudau <liviu.dudau@arm.com>
> Fixes: 59ce4039727ef40 ("of: reserved_mem: add support for using more than
> one region for given device")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/of/of_reserved_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] of: reserved_mem: restore old behavior when no region is defined
2016-06-08 13:05 ` Rob Herring
@ 2016-06-08 15:35 ` Sumit Semwal
0 siblings, 0 replies; 5+ messages in thread
From: Sumit Semwal @ 2016-06-08 15:35 UTC (permalink / raw)
To: Rob Herring
Cc: Marek Szyprowski, devicetree@vger.kernel.org, Kamil Debski,
linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz,
Daniel Vetter, Mauro Carvalho Chehab, Liviu Dudau,
Krzysztof Kozlowski, dri-devel, Javier Martinez Canillas,
Sylwester Nawrocki, Robin Murphy,
linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org
On 8 June 2016 at 18:35, Rob Herring <robh@kernel.org> wrote:
> On Wed, Jun 8, 2016 at 1:51 AM, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> Change return value back to -ENODEV when no region is defined for given
>> device. This restores old behavior of this function, as some drivers rely
>> on such error code.
>>
>> Reported-by: Liviu Dudau <liviu.dudau@arm.com>
>> Fixes: 59ce4039727ef40 ("of: reserved_mem: add support for using more than
>> one region for given device")
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> drivers/of/of_reserved_mem.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Looks reasonable; FWIW
Reviewed-by: Sumit Semwal <sumit.semwal@linaro.org>
> Acked-by: Rob Herring <robh@kernel.org>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Thanks and regards,
Sumit Semwal
Linaro Mobile Group - Kernel Team Lead
Linaro.org │ Open source software for ARM SoCs
^ permalink raw reply [flat|nested] 5+ messages in thread