From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Date: Wed, 8 Jun 2016 12:45:39 +0200 Message-ID: <5757F753.8010408@atmel.com> References: <1465359311-14544-1-git-send-email-wenyou.yang@atmel.com> <1465359311-14544-2-git-send-email-wenyou.yang@atmel.com> <5757EDB4.3020806@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <5757EDB4.3020806-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wenyou Yang , Alan Stern , Greg Kroah-Hartman , Rob Herring , Alexandre Belloni Cc: Pawel Moll , Mark Brown , Ian Campbell , Kumar Gala , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Le 08/06/2016 12:04, Nicolas Ferre a =E9crit : > Le 08/06/2016 06:15, Wenyou Yang a =E9crit : >> In order to the save power consumption, as a workaround, suspend >> forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI >> Interrupt Configuration Register in the SFRs while OHCI USB suspend. >> >> This suspend operation must be done before the USB clock is disabled= , >> resume after the USB clock is enabled. >> >> Signed-off-by: Wenyou Yang >=20 > Little nitpicking below... >=20 >> --- >> >> Changes in v3: >> - Change the compatible description for more precise. >> >> Changes in v2: >> - Add compatible to support forcibly suspend the ports. >> - Add soc/at91/at91_sfr.h to accommodate the defines. >> - Add error checking for .sfr_regmap. >> - Remove unnecessary regmap_read() statement. >> >> .../devicetree/bindings/usb/atmel-usb.txt | 6 +- >> drivers/usb/host/ohci-at91.c | 80 +++++++++++= ++++++++++- >> include/soc/at91/at91_sfr.h | 29 ++++++++ Oops sorry, additional comment which is not nitpicking, this one: We already have SFR header file in this patch: Author: Cyrille Pitchen Date: Thu Mar 17 17:04:00 2016 +0100 ARM: dts: at91: sama5d2: add SFR node This SFR node is looked up by the I2S controller driver to tune the SFR_I2SCLKSEL register. Signed-off-by: Cyrille Pitchen Signed-off-by: Ludovic Desroches Acked-by: Alexandre Belloni Acked-by: Rob Herring Signed-off-by: Nicolas Ferre Which is already accepted by arm-soc guys for 4.7... So my ack transforms into a nack, sorry... We will have to coordinate the effort and maybe take the whole series with us. But for sure, you'll have to use the existing include/soc/at91/atmel-sfr.h file and build on top of it... Bye, >> 3 files changed, 112 insertions(+), 3 deletions(-) >> create mode 100644 include/soc/at91/at91_sfr.h [..] >=20 > But you can take my: >=20 > Acked-by: Nicolas Ferre >=20 > with the little corrections listed. >=20 > Alan, We plan to take the second patch of this series with AT91 git t= ree > through arm-soc. Do you agree to take this one through yours? Alan, forget this request, we'll have to coordinate differently. Sorry for the noise. Bye, --=20 Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html