From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property Date: Thu, 09 Jun 2016 07:11:32 +0200 Message-ID: <5758FA84.3050909@samsung.com> References: <1464768141-25420-1-git-send-email-k.kozlowski@samsung.com> <1464768141-25420-7-git-send-email-k.kozlowski@samsung.com> <20160603020218.GA19436@rob-hp-laptop> <575693DE.2010603@samsung.com> <20160608190333.GA5126@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chen-Yu Tsai , Rob Herring Cc: Mark Rutland , devicetree , Ulf Hansson , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll , Ian Campbell , Dmitry Eremin-Solenikov , Greg Kroah-Hartman , linux-usb , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Sebastian Reichel , linux-kernel , Javier Martinez Canillas , Bartlomiej Zolnierkiewicz , Kukjin Kim , Alan Stern , linux-arm-kernel , Kumar Gala , David Woodhouse , hzpeterchen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-pm-u79uwXL29TaqPxH82wqD4g@public.gmane.org List-Id: devicetree@vger.kernel.org On 06/09/2016 04:34 AM, Chen-Yu Tsai wrote: > Hi > > On Thu, Jun 9, 2016 at 3:03 AM, Rob Herring wrote: >> On Tue, Jun 07, 2016 at 11:29:02AM +0200, Krzysztof Kozlowski wrote: >>> On 06/03/2016 04:02 AM, Rob Herring wrote: >>>>> Optional properties: >>>>> - reset-gpios : contains a list of GPIO specifiers. The reset GPIOs are asserted >>>>> @@ -16,6 +22,7 @@ Optional properties: >>>>> See ../clocks/clock-bindings.txt for details. >>>>> - clock-names : Must include the following entry: >>>>> "ext_clock" (External clock provided to the card). >>>>> +- ext-supply : External regulator supply >>>> >>>> What happens when there are 2 supplies? >>>> >>>> I'd prefer the name not be genericish and use the real supply names. >>>> Then the power seq code should just turn on all supplies it finds. If >>>> the order or timing to turn on matters, then sorry, no generic sequence. >>> >>> I think the generic part for regulators might be a problem. Regulator >>> API requires a name for the supply... it cannot get "something" or >>> "everything". >> >> That's the downside of variable property names... >> >>> The driver could attach itself to any kind of node (where power-sequence >>> property exists) so the supply name depends on the bindings of device >>> (not bindings of power sequence driver). >>> >>> The power sequence driver could however iterate over child properties >>> and get the names of all supplies. It is a little bit ugly... >> >> Yes. Like this, right? >> >> for_each_property_of_node(np, pp) { >> if (!strstr(pp->name, "-supply")) >> continue; >> // found supply >> } >> >> The uglyness can always be improved with a function to do this parsing. > > There's already a version of this in simplefb. Maybe it's time to move > this to a common function? Thanks, I'll make a generic one and let's see how Mark will respond to it. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html