From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [RFC v4 2/7] Revert "extcon: usb-gpio: switch to use pm wakeirq apis" Date: Thu, 09 Jun 2016 10:10:38 +0200 Message-ID: <5759247E.6060901@samsung.com> References: <1465393686-16644-1-git-send-email-k.kozlowski@samsung.com> <1465393686-16644-3-git-send-email-k.kozlowski@samsung.com> <57592220.9030201@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <57592220.9030201@ti.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Roger Quadros , MyungJoo Ham , Chanwoo Choi , Rob Herring , Mark Rutland , Kukjin Kim , Marek Szyprowski , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Peter Chen , "Ivan T. Ivanov" , Felipe Balbi , kishon@ti.com, Bartlomiej Zolnierkiewicz List-Id: devicetree@vger.kernel.org On 06/09/2016 10:00 AM, Roger Quadros wrote: > -balbi@ti > +balbi@kernel > > Hi, > > On 08/06/16 16:48, Krzysztof Kozlowski wrote: >> This reverts commit 8106e404174253639731cc30a44f5b3ab764c5b7. > > The above commit id is not present in v4.7-rc1 and this patch doesn't apply properly. > Can you please rebase this series on v4.7-rc1? The commit is present in extcon tree for v4.8. The extcon patches will be applied (probably) to that tree so what is the point of rebasing on v4.7-rc1? Also the point of this particular patch is to show that previous change should be just dropped. Don't replace things to complicated devm-like functions just to simplify one path in the driver... Best regards, Krzysztof