devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keerthy <a0393675@ti.com>
To: Keerthy <j-keerthy@ti.com>, tony@atomide.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com, d-gerlach@ti.com,
	nm@ti.com, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Franklin S Cooper Jr <fcooper@ti.com>,
	Aparna Balasubramanian <aparnab@ti.com>
Subject: Re: [tiL4.4-P PATCH] ARM: dts: am437x-sk-evm: Reduce i2c0 bus speed for tps65218
Date: Wed, 15 Jun 2016 11:45:02 +0530	[thread overview]
Message-ID: <5760F266.5060309@ti.com> (raw)
In-Reply-To: <1465971211-15994-1-git-send-email-j-keerthy@ti.com>



On Wednesday 15 June 2016 11:43 AM, Keerthy wrote:
> From: Dave Gerlach <d-gerlach@ti.com>
>
> Based on the latest timing specifications for the TPS65218 from the data
> sheet, http://www.ti.com/lit/ds/symlink/tps65218.pdf, document SLDS206
> from November 2014, we must change the i2c bus speed to better fit within
> the minimum high SCL time required for proper i2c transfer.
>
> When running at 400khz, measurements show that SCL spends
> 0.8125 uS/1.666 uS high/low which violates the requirement for minimum
> high period of SCL provided in datasheet Table 7.6 which is 1 uS.
> Switching to 100khz gives us 5 uS/5 uS high/low which both fall above
> the minimum given values for 100 khz, 4.0 uS/4.7 uS high/low.
>
> Without this patch occasionally a voltage set operation from the kernel
> will appear to have worked but the actual voltage reflected on the PMIC
> will not have updated, causing problems especially with cpufreq that may
> update to a higher OPP without actually raising the voltage on DCDC2,
> leading to a hang.

I will resend with proper $Subject. Sorry for the noise. Please ignore 
this patch.

>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> Signed-off-by: Aparna Balasubramanian <aparnab@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>   arch/arm/boot/dts/am437x-sk-evm.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
> index 18a3445..5f67001 100644
> --- a/arch/arm/boot/dts/am437x-sk-evm.dts
> +++ b/arch/arm/boot/dts/am437x-sk-evm.dts
> @@ -490,7 +490,7 @@
>   	status = "okay";
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&i2c0_pins>;
> -	clock-frequency = <400000>;
> +	clock-frequency = <100000>;
>
>   	tps@24 {
>   		compatible = "ti,tps65218";
>

      reply	other threads:[~2016-06-15  6:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15  6:13 [tiL4.4-P PATCH] ARM: dts: am437x-sk-evm: Reduce i2c0 bus speed for tps65218 Keerthy
2016-06-15  6:15 ` Keerthy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5760F266.5060309@ti.com \
    --to=a0393675@ti.com \
    --cc=aparnab@ti.com \
    --cc=d-gerlach@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fcooper@ti.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).