From: Sudeep Holla <sudeep.holla@arm.com>
To: Rob Rice <rob.rice@broadcom.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
linux-kernel@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Anup Patel <anup.patel@broadcom.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Rob Rice <rrice@broadcom.com>
Subject: Re: [PATCH RESEND 1/3] dt-bindings: add bindings documentation for PDC driver.
Date: Thu, 16 Jun 2016 14:51:44 +0100 [thread overview]
Message-ID: <5762AEF0.9030203@arm.com> (raw)
In-Reply-To: <CAG4BRpnP_qqffLF9X+RusNQGnrtARap9HmK4RE4_jSVfO5juGQ@mail.gmail.com>
On 16/06/16 14:50, Rob Rice wrote:
>
>
> On Tue, Jun 14, 2016 at 10:42 AM, Sudeep Holla <sudeep.holla@arm.com
> <mailto:sudeep.holla@arm.com>> wrote:
>
>
>
> On 14/06/16 15:02, Rob Rice wrote:
>
> From: Rob Rice <rrice@broadcom.com <mailto:rrice@broadcom.com>>
>
> Add the device tree binding documentation for the PDC hardware
> in Broadcom iProc SoCs.
>
> Signed-off-by: Rob Rice <rob.rice@broadcom.com
> <mailto:rob.rice@broadcom.com>>
> Acked-by: Rob Herring <robh@kernel.org <mailto:robh@kernel.org>>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com
> <mailto:ray.jui@broadcom.com>>
> Reviewed-by: Anup Patel <anup.patel@broadcom.com
> <mailto:anup.patel@broadcom.com>>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com
> <mailto:scott.branden@broadcom.com>>
> ---
> .../bindings/mailbox/brcm,iproc-pdc-mbox.txt | 23
> ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt
>
> diff --git
> a/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt
> b/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt
> new file mode 100644
> index 0000000..411ccf4
> --- /dev/null
> +++
> b/Documentation/devicetree/bindings/mailbox/brcm,iproc-pdc-mbox.txt
> @@ -0,0 +1,23 @@
> +The PDC driver manages data transfer to and from various
> offload engines
> +on some Broadcom SoCs. An SoC may have multiple PDC hardware
> blocks. There is
> +one device tree entry per block.
> +
> +Required properties:
> +- compatible : Should be "brcm,iproc-pdc-mbox".
> +- reg: Should contain PDC registers location and length.
> +- interrupts: Should contain the IRQ line for the PDC.
> +- #mbox-cells: 1
> +- brcm,rx-status-len: Length of metadata preceding received
> frames, in bytes.
> +
>
>
> Ideally the metadata is more associated with the software protocol built
> on top of the mailbox controller.
>
> Is this metadata added by the hardware ?
>
> Otherwise it's better to make it part of the protocol rather than the
> associating with the controller.
>
>
> Yes, in fact this metadata is added by the PDC hardware itself. So it
> seems correct for the DT property to be on the controller.
In that case, it's fine.
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-06-16 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 14:02 [PATCH RESEND 0/3] Add Broadcom PDC mailbox driver Rob Rice
2016-06-14 14:02 ` [PATCH RESEND 1/3] dt-bindings: add bindings documentation for PDC driver Rob Rice
[not found] ` <1465912965-35500-2-git-send-email-rob.rice-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-06-14 14:42 ` Sudeep Holla
2016-06-16 13:50 ` Rob Rice
2016-06-16 13:51 ` Sudeep Holla [this message]
2016-06-14 14:02 ` [PATCH RESEND 2/3] mailbox: Add Broadcom PDC mailbox driver Rob Rice
[not found] ` <1465912965-35500-3-git-send-email-rob.rice-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-06-14 14:07 ` Scott Branden
2016-06-14 14:02 ` [PATCH RESEND 3/3] arm64: dts: Add Broadcom Northstar2 device tree entries for PDC driver Rob Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5762AEF0.9030203@arm.com \
--to=sudeep.holla@arm.com \
--cc=anup.patel@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jassisinghbrar@gmail.com \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rjui@broadcom.com \
--cc=rob.rice@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=rrice@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).