From: Timur Tabi <timur@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, sdharia@codeaurora.org,
shankerd@codeaurora.org, vikrams@codeaurora.org,
cov@codeaurora.org, gavidov@codeaurora.org, andrew@lunn.ch,
bjorn.andersson@linaro.org, mlangsdo@redhat.com, jcm@redhat.com,
agross@codeaurora.org, davem@davemloft.net, f.fainelli@gmail.com
Subject: Re: [PATCH] [v5] net: emac: emac gigabit ethernet controller driver
Date: Mon, 20 Jun 2016 13:49:10 -0500 [thread overview]
Message-ID: <57683AA6.7020302@codeaurora.org> (raw)
In-Reply-To: <20160619141757.GA4249@rob-hp-laptop>
Rob Herring wrote:
>> >+ interrupt-parent = <&emac0>;
>> >+ #interrupt-cells = <1>;
>> >+ interrupts = <0 1>;
>> >+ interrupt-map-mask = <0xffffffff>;
>> >+ interrupt-map = <0 &intc 0 76 0
>> >+ 1 &intc 0 80 0>;
> Why? This looks unnecessary.
It may have made sense with an earlier version of the driver that had
more complex interrupts. I'll fix it in v6.
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.
prev parent reply other threads:[~2016-06-20 18:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 22:22 [PATCH] [v5] net: emac: emac gigabit ethernet controller driver Timur Tabi
2016-06-16 4:41 ` David Miller
2016-06-16 5:05 ` Timur Tabi
2016-06-19 14:17 ` Rob Herring
2016-06-20 17:41 ` Timur Tabi
2016-06-20 18:04 ` Shanker Donthineni
2016-06-20 18:15 ` Timur Tabi
2016-06-20 18:49 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57683AA6.7020302@codeaurora.org \
--to=timur@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=cov@codeaurora.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gavidov@codeaurora.org \
--cc=jcm@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mlangsdo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sdharia@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=vikrams@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).