From mboxrd@z Thu Jan 1 00:00:00 1970 From: fixed-term.Oleksij.Rempel Subject: Re: [PATCH 2/4] dt/bindings: Add bindings for Micro Crystal rv8803 Date: Wed, 22 Jun 2016 07:15:12 +0200 Message-ID: <576A1EE0.4000603@de.bosch.com> References: <1466492240-5528-1-git-send-email-dirk.behme@de.bosch.com> <1466492240-5528-2-git-send-email-dirk.behme@de.bosch.com> <20160621214836.GA10197@rob-hp-laptop> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20160621214836.GA10197@rob-hp-laptop> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Rob Herring , Dirk Behme Cc: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 21.06.2016 23:48, Rob Herring wrote: > On Tue, Jun 21, 2016 at 08:57:18AM +0200, Dirk Behme wrote: >> From: Oleksij Rempel >> >> ... and Epson RX8900 real time clock >> >> Signed-off-by: Oleksij Rempel >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> --- >> .../devicetree/bindings/rtc/epson,rx8900.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8900.txt >> >> diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.txt b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt >> new file mode 100644 >> index 0000000..51959de >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt >> @@ -0,0 +1,21 @@ >> +Real Time Clock driver for: >> + - Epson RX8900 >> + - Micro Crystal rv8803 >> + >> +Required properties: >> +- compatible: should be: "mc,rv8803" or "epson,rx8900" >> +- reg : the I2C address of the device for I2C >> + >> +Optional properties: >> +- epson,vdetoff : Disable Voltage Detector. Should be set if no >> + backup battery is used. > > set to no? Looks like a boolean to me. > > How about epson,vdet-disable to be consistent. > >> +- trickle-diode-disable : Disable internal trickle charger diode > > boolean? > > Needs a vendor prefix. This is common name used by many rtc driver without vendor prefix. -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.