From mboxrd@z Thu Jan  1 00:00:00 1970
From: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: sun7i: Add BCM53125 Device Tree nodes
Date: Sat, 25 Jun 2016 19:59:23 -0700
Message-ID: <576F450B.3080207@gmail.com>
References: <1465690459-30751-1-git-send-email-f.fainelli@gmail.com>
 <1465690459-30751-2-git-send-email-f.fainelli@gmail.com>
 <CAGb2v64u74cXG0R-MSMtDBxBpg2tFoifQwqbvWL-+3pG=GLVTQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
In-Reply-To: <CAGb2v64u74cXG0R-MSMtDBxBpg2tFoifQwqbvWL-+3pG=GLVTQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: linux-arm-kernel <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>, devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>, Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>, vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org, Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
List-Id: devicetree@vger.kernel.org

Le 23/06/2016 22:48, Chen-Yu Tsai a =C3=A9crit :
>> diff --git a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts b/arch/arm/bo=
ot/dts/sun7i-a20-lamobo-r1.dts
>> index 5ee43d8bf174..697582397dcf 100644
>> --- a/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
>> +++ b/arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts
>> @@ -110,13 +110,67 @@
>>  &gmac {
>>         pinctrl-names =3D "default";
>>         pinctrl-0 =3D <&gmac_pins_rgmii_a>;
>> -       phy =3D <&phy1>;
>>         phy-mode =3D "rgmii";
>>         phy-supply =3D <&reg_gmac_3v3>;
>>         status =3D "okay";
>>
>> -       phy1: ethernet-phy@1 {
>> -               reg =3D <1>;
>> +       fixed-link {
>> +               speed =3D <1000>;
>> +               full-duplex;
>> +       };
>> +
>> +       mdio1 {
>=20
> mdio will suffice.

There is another label in sun7i-a20.dtsi named mdio which is for the
MDIO controller node matching allwinner,sun4i-a10-mdio, which is not th=
e
one we want here, we want the MDIO controller associated with the
Synopsys GMAC.

>=20
>> +               compatible =3D "snps,dwmac-mdio";
>> +               #address-cells =3D <1>;
>> +               #size-cells =3D <0>;
>> +
>> +               switch: ethernet-switch@30 {
>=20
> 30 decimal or 0x30 hex? We typically use hex values here.

30 decimal, will fix that.
--=20
=46lorian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" i=
n
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html