From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C20CBC43217 for ; Thu, 3 Nov 2022 15:27:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232204AbiKCP13 (ORCPT ); Thu, 3 Nov 2022 11:27:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232214AbiKCP1O (ORCPT ); Thu, 3 Nov 2022 11:27:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7E1D1B1FD; Thu, 3 Nov 2022 08:27:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1751361F3F; Thu, 3 Nov 2022 15:27:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1E4BC433D6; Thu, 3 Nov 2022 15:27:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667489232; bh=9B6TUpcxiiK6nYvO+tZ9kBnE+5WGkzDACOo23ch8WCA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=tZ5WpOZ7axSdC5g+29cT7yfgHFK7yRD4IMa9dxMheFgkrT+RotkRJIfGpMbS8c2oB GLepVRcm47TWGrS8XxZEjPXQd/dhZ6MHaRdTgQE31CF/NUJyg5qIHfYpybQjsxv1Sz H2ohLNem3YsF5qko+37yaXfV8sIS4HQIKF6qKwpuokjcSPbDtfVxb/xymZ2rriGS6M ddt5ca0zSqtZofSKXTQ+7ZluG2cY4BnUqNrxvVVUcEo4//EFGYCwRch+2ymfS8cz/T BrzbhTK7MwpypzEP6XkeN5A91xn5vzWYaYa2FDwBHNazQQjScK29irhQTMFeGE2Bhn 0tGxzRJKJruRQ== Message-ID: <576c42c4-1256-304d-3513-7bf02cddb220@kernel.org> Date: Thu, 3 Nov 2022 11:27:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/3] dt-bindings: Add bindings for aspeed pwm-tach. Content-Language: en-US To: Billy Tsai , "jdelvare@suse.com" , "linux@roeck-us.net" , "robh+dt@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "lee.jones@linaro.org" , "thierry.reding@gmail.com" , "u.kleine-koenig@pengutronix.de" , "p.zabel@pengutronix.de" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , BMC-SW , "garnermic@meta.com" References: <20221031103809.20225-1-billy_tsai@aspeedtech.com> <20221031103809.20225-2-billy_tsai@aspeedtech.com> <2508B515-E153-42C2-B013-2A64A110BCF2@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <2508B515-E153-42C2-B013-2A64A110BCF2@aspeedtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/11/2022 06:36, Billy Tsai wrote: > > On 2022/11/3, 5:20 AM, "Krzysztof Kozlowski" wrote: > > On 31/10/2022 06:38, Billy Tsai wrote: > > > +patternProperties: > > > + "^pwm(@[0-9a-f]+)?$": > > > + $ref: ../pwm/aspeed,ast2600-pwm.yaml > > > Full path, so: /schemas/pwm/aspeed,ast2600-pwm.yaml > > > Why unit addresses are optional? > > > > + > > > + "^tach(@[0-9a-f]+)?$": > > > + $ref: ../hwmon/aspeed,ast2600-tach.yaml > > > Ditto > > > Why unit addresses are optional? > > The pwm_tach is not the bus. I will use > pwm: > type: object > $ref: "/schemas/pwm/aspeed,ast2600-pwm.yaml" > > tach: > type: object > $ref: "/schemas/hwmon/aspeed,ast2600-tach.yaml" > to replace it. > > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + #include > > > + pwm_tach: pwm_tach@1e610000 { > > > Node names should be generic. > > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > This is the mfd with pwm and tach, so they are combined as the node name. > > > No underscores in node names. > > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#table-1 > I see that the underscore is the valid characters for node names. > Did I miss any information? W=2 warnings. Best regards, Krzysztof