From: Keerthy <a0393675@ti.com>
To: Lee Jones <lee.jones@linaro.org>, Keerthy <j-keerthy@ti.com>
Cc: dmitry.torokhov@gmail.com, linus.walleij@linaro.org,
gnurou@gmail.com, broonie@kernel.org, tony@atomide.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-input@vger.kernel.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 02/10] Documentation: regulator: tps65218: Update examples
Date: Tue, 28 Jun 2016 13:15:14 +0530 [thread overview]
Message-ID: <57722B0A.2070706@ti.com> (raw)
In-Reply-To: <20160628065950.GE6720@dell>
On Tuesday 28 June 2016 12:29 PM, Lee Jones wrote:
> This is a more common format for DT bindings:
>
> dt-bindings: regulator:
>
> On Tue, 28 Jun 2016, Keerthy wrote:
>> This updates the device tree according to the preferred way of parsing
>
> Nit: Device Tree
Okay.
>
>> the nodes using the regulator framework.
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> .../devicetree/bindings/regulator/tps65218.txt | 87 ++++++++++++++++++----
>> 1 file changed, 71 insertions(+), 16 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/tps65218.txt b/Documentation/devicetree/bindings/regulator/tps65218.txt
>> index fccc1d2..5e1888f 100644
>> --- a/Documentation/devicetree/bindings/regulator/tps65218.txt
>> +++ b/Documentation/devicetree/bindings/regulator/tps65218.txt
>> @@ -1,23 +1,78 @@
>> TPS65218 family of regulators
>>
>> Required properties:
>> -For tps65218 regulators/LDOs
>> -- compatible:
>> - - "ti,tps65218-dcdc1" for DCDC1
>> - - "ti,tps65218-dcdc2" for DCDC2
>> - - "ti,tps65218-dcdc3" for DCDC3
>> - - "ti,tps65218-dcdc4" for DCDC4
>> - - "ti,tps65218-dcdc5" for DCDC5
>> - - "ti,tps65218-dcdc6" for DCDC6
>> - - "ti,tps65218-ldo1" for LDO1
>> -
>> -Optional properties:
>> -- Any optional property defined in bindings/regulator/regulator.txt
>> +- compatible: "ti,tps65218"
>> +- reg: I2C slave address
>
> '\n' here for clarity.
Okay.
>
>> +- list of regulators provided by this controller, must be named
>
> Sentences start with an uppercase char.
Okay.
>
>> + after their hardware counterparts: dcdc[1-6] and ldo1
>> +- This is the list of child nodes that specify the regulator
>> + initialization data for defined regulators. Not all regulators for the given
>> + device need to be present. The definition for each of these nodes is defined
>> + using the standard binding for regulators found at
>> + Documentation/devicetree/bindings/regulator/regulator.txt.
>
> Use relative path names for brevity.
Okay.
>
> ./regulator.txt
>
>> + The valid names for regulators are:
>> + tps65217: regulator-dcdc1, regulator-dcdc2, regulator-dcdc3, regulator-dcdc4,
>> + regulator-dcdc5, regulator-dcdc6, regulator-ldo1, regulator-ls3
>> + Each regulator is defined using the standard binding for regulators.
>>
>> Example:
>> +tps65218: tps65218@24 {
>
> Is this label used?
Yes. This can be used in the dts files.
>
>> + reg = <0x24>;
>> + compatible = "ti,tps65218";
>> + interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; /* NMIn */
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>
> [...]
>
next prev parent reply other threads:[~2016-06-28 7:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 6:06 [PATCH v3 00/10] mfd: tps65218: Clean ups Keerthy
2016-06-28 6:06 ` [PATCH v3 01/10] mfd: tps65218: Remove redundant read wrapper Keerthy
2016-06-28 7:00 ` Lee Jones
2016-06-28 7:01 ` Keerthy
2016-06-28 6:06 ` [PATCH v3 02/10] Documentation: regulator: tps65218: Update examples Keerthy
2016-06-28 6:59 ` Lee Jones
2016-06-28 7:45 ` Keerthy [this message]
2016-06-28 6:06 ` [PATCH v3 03/10] input: tps65218-pwrbutton: Add platform_device_id table Keerthy
[not found] ` <1467093980-11458-4-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2016-06-28 6:25 ` kbuild test robot
2016-06-28 6:33 ` kbuild test robot
2016-06-28 6:49 ` Lee Jones
2016-06-28 6:55 ` Keerthy
2016-06-28 7:41 ` Lee Jones
2016-06-28 7:43 ` Keerthy
2016-06-28 6:06 ` [PATCH v3 04/10] mfd: tps65218: Use mfd_add_devices instead of of_platform_populate Keerthy
2016-06-28 6:54 ` Lee Jones
2016-06-28 6:06 ` [PATCH v3 05/10] regulator: tps65218: Remove all the compatibles Keerthy
2016-06-28 6:06 ` [PATCH v3 06/10] gpio: tps65218: Remove the compatible Keerthy
2016-06-28 6:52 ` Lee Jones
2016-06-28 6:59 ` Keerthy
2016-06-28 6:06 ` [PATCH v3 07/10] ARM: dts: AM437X-GP-EVM: Remove redundant regulator compatibles Keerthy
2016-06-28 6:06 ` [PATCH v3 08/10] ARM: dts: AM437X-SK-EVM: " Keerthy
2016-06-28 6:06 ` [PATCH v3 09/10] ARM: dts: AM437X-CM-T43: " Keerthy
2016-06-28 6:06 ` [PATCH v3 10/10] ARM: dts: AM43X-EPOS-EVM: " Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57722B0A.2070706@ti.com \
--to=a0393675@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gnurou@gmail.com \
--cc=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).