Re: [PATCH 1/2] dt-bindings: tc358767: add DT documentation

[Archit Taneja <architt@codeaurora.org>]

Hi,

On 07/01/2016 08:20 PM, Philipp Zabel wrote:
> Add DT binding documentation for the Toshiba TC358767 eDP bridge.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>   .../bindings/display/bridge/toshiba,tc358767.txt   | 48 ++++++++++++++++++++++
>   1 file changed, 48 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt
> new file mode 100644
> index 0000000..c58a59f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.txt
> @@ -0,0 +1,48 @@
> +Toshiba TC358767 eDP bridge bindings
> +
> +Required properties:
> + - compatible: "toshiba,tc358767"
> + - reg: i2c address of the bridge, 0x68 or 0x0f, depending on bootstrap pins
> + - clock-names: should be "ref"
> + - clocks: OF device-tree clock specification for refclk input. The reference

Should we have this as an optional property? There could be platforms
where an oscillator output on the board connects directly to the refclk
pin, without any option to gate it.

> +   clock rate must be 13 MHz, 19.2 MHz, 26 MHz, or 38.4 MHz.
> +
> +Optional properties:
> + - shutdown-gpios: OF device-tree gpio specification for SD pin
> +                   (active high shutdown input)
> + - reset-gpios: OF device-tree gpio specification for RSTX pin
> +                (active low system reset)
> + - ports: the ports node can contain video interface port nodes to connect
> +   to a DPI/DSI source and to an eDP/DP sink according to [1][2].

Just wondering about the future when DSI is implemented. Would we have
different port numbers for DSI and DPI? And figure whether the input
is DSI or DPI based on input the port number? If we go with that
approach, it might make sense to have the bridge output port number
as 2.

Thanks,
Archit

> +
> +[1]: Documentation/devicetree/bindings/graph.txt
> +[2]: Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Example:
> +	edp-bridge@68 {
> +		compatible = "toshiba,tc358767";
> +		reg = <0x68>;
> +		shutdown-gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&gpio3 24 GPIO_ACTIVE_LOW>;
> +		clock-names = "ref";
> +		clocks = <&edp_refclk>;
> +
> +		ports {
> +			port@0 {
> +				reg = <0>;
> +
> +				bridge_in: endpoint {
> +					remote-endpoint = <&dpi_out>;
> +				};
> +			};
> +
> +			port@1 {
> +				reg = <1>;
> +
> +				bridge_out: endpoint {
> +					remote-endpoint = <&panel_in>;
> +				};
> +			};
> +		};
> +	};
> +
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel