From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabriel Fernandez Subject: Re: [PATCH 3/4] drivers: reset: Add STM32 reset driver Date: Tue, 5 Jul 2016 09:29:46 +0200 Message-ID: <577B61EA.5080703@st.com> References: <1467640052-6770-1-git-send-email-gabriel.fernandez@st.com> <1467640052-6770-3-git-send-email-gabriel.fernandez@st.com> <1467653810.2224.77.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1467653810.2224.77.camel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Philipp Zabel Cc: Rob Herring , Mark Rutland , Maxime Coquelin , Russell King , patrice.chotard-qxv4g6HH51o@public.gmane.org, alexandre.torgue-qxv4g6HH51o@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Philipp, Thanks for reviewing. On 07/04/2016 07:36 PM, Philipp Zabel wrote: > Hi Gabriel, > > Am Montag, den 04.07.2016, 15:47 +0200 schrieb gabriel.fernandez-qxv4g6HH51o@public.gmane.org: >> From: Gabriel Fernandez > Isn't Maxime the author of this driver? Yes i upstream with his agreement. I only made small modifications (use of devm_reset_controller_register(), make reset_control_ops const...) that's why the author in the git history has been changed... I will use g |it commit --amend --author="Maxime.." for the v2. | >> The STM32 MCUs family IPs can be reset by accessing some registers >> from the RCC block. >> >> The list of available reset lines is documented in the DT bindings. >> >> Signed-off-by: Maxime Coquelin >> Signed-off-by: Gabriel Fernandez >> --- >> drivers/reset/Makefile | 1 + >> drivers/reset/reset-stm32.c | 113 ++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 114 insertions(+) >> create mode 100644 drivers/reset/reset-stm32.c >> >> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile >> index 03dc1bb..3776b7b 100644 >> --- a/drivers/reset/Makefile >> +++ b/drivers/reset/Makefile > [...] >> +static const struct reset_control_ops stm32_reset_ops = { >> + .assert = stm32_reset_assert, >> + .deassert = stm32_reset_deassert, > Are the registers not readable, or did you choose not to > implement .status on purpose? We choose to not implement. Thanks! Best Regards Gabriel > regards > Philipp > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html